feat: wallet ownership validation for eth-like, ada, apt, vet, icp #7561
+617
−195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielzhao122
requested review from
adityasoni-bitgo,
mohammadalfaiyazbitgo and
zahin-mohammad
Contributor
zahin-mohammad
left a comment
zahin-mohammad
left a comment
There was a problem hiding this comment.
PR will be split by coin.
|
|
||
| async isWalletAddress(params: TssVerifyAddressOptions): Promise<boolean> { | ||
| return this.isValidAddress(params.address); | ||
| const { address } = params; |
Contributor
There was a problem hiding this comment.
Looks like there might be a difference between wallet version 1 and other wallet versions. Double check if the address verification is the same between these 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
AbstractEthLikeNewCoins.isWalletAddressforwarder version bypassreturn truefor versions 0, 3, 5Fix partial implementations for
ada,apt,icp,vetticket: WP-6461