Skip to content

#237 remove enable minting button#242

Merged
JulianVIE merged 3 commits intodevfrom
237-remove-enable-minting-button
Mar 5, 2026
Merged

#237 remove enable minting button#242
JulianVIE merged 3 commits intodevfrom
237-remove-enable-minting-button

Conversation

@JulianVIE
Copy link

No description provided.

Copilot AI review requested due to automatic review settings March 4, 2026 12:30
@JulianVIE JulianVIE self-assigned this Mar 4, 2026
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 4, 2026

Deploying wildcat-dashboard with  Cloudflare Pages  Cloudflare Pages

Latest commit: 346440b
Status: ✅  Deploy successful!
Preview URL: https://3f611d98.wildcat-dashboard.pages.dev
Branch Preview URL: https://237-remove-enable-minting-bu.wildcat-dashboard.pages.dev

View logs

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the “Enable minting” action from the quotes UI and cleans up the related client/API surface, updating the OpenAPI spec and regenerating the TypeScript SDK/react-query wrappers accordingly.

Changes:

  • Removed the enable-minting mutation/handler from useQuoteMutations and removed the enable-minting confirm UI from QuoteActions.
  • Updated QuotePage to stop passing the removed mintingEnabled prop into QuoteActions.
  • Updated OpenAPI + regenerated client code to remove postEnableQuoteMinting and adjust quote status typing; also (re)introduced postTokenStatus in the generated SDK.

Reviewed changes

Copilot reviewed 5 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/pages/quotes/components/useQuoteMutations.ts Removes the enable-minting mutation + handler from quote mutations hook.
src/pages/quotes/QuotePage.tsx Stops passing mintingEnabled into QuoteActions.
src/pages/quotes/QuoteActions.tsx Removes the enable-minting confirm drawer/button and associated state/i18n strings.
src/generated/client/types.gen.ts Regenerated API types (removes enable-minting types; modifies quote status union; modifies ebill-mint-complete request type).
src/generated/client/sdk.gen.ts Regenerated SDK (removes postEnableQuoteMinting; moves/updates postTokenStatus; changes getEbillMintComplete signature).
src/generated/client/index.ts Removes exports/types for the removed enable-minting endpoint.
src/generated/client/client/client.gen.ts Adds a TODO comment in generated client error handling branch.
src/generated/client/@tanstack/react-query.gen.ts Regenerated react-query wrappers (removes enable-minting mutation; adjusts token-status and ebill-mint-complete helpers).
opt/wildcat/openapi.json Updates OpenAPI spec (removes enable-mint endpoint; modifies quote status schema; adjusts ebill payment-complete path).
opt/wildcat/backup/_openapi.json Updates backup OpenAPI snapshot with related endpoint/schema changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.27%. Comparing base (8623299) to head (346440b).
⚠️ Report is 1 commits behind head on dev.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #242      +/-   ##
==========================================
- Coverage   74.41%   74.27%   -0.14%     
==========================================
  Files          32       32              
  Lines        1110     1104       -6     
  Branches      464      446      -18     
==========================================
- Hits          826      820       -6     
  Misses        275      275              
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JulianVIE JulianVIE merged commit 1f31e33 into dev Mar 5, 2026
4 checks passed
@JulianVIE JulianVIE deleted the 237-remove-enable-minting-button branch March 5, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants