Adding fromModelDirectory methods to various models#144
Merged
lucasnewman merged 1 commit intoBlaizzy:mainfrom Apr 6, 2026
Merged
Adding fromModelDirectory methods to various models#144lucasnewman merged 1 commit intoBlaizzy:mainfrom
lucasnewman merged 1 commit intoBlaizzy:mainfrom
Conversation
lucasnewman
approved these changes
Apr 6, 2026
Collaborator
lucasnewman
left a comment
lucasnewman
left a comment
There was a problem hiding this comment.
Thanks! This is useful and probably should have been there all along :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There are various models in this package that contain a
fromModelDirectorymethod to instantiate them directly from pre-downloaded locations. However they are missing from some models.This PR adds those in a very conservative typographic manner, creating the method and using it at the tail end of the existing
fromPretrainedmethod, following the pattern in other model files. Any extra parameters that may need cross over across aside from the model URL are given the same defaults that the originalfromPretrainedmethod applies.Notes
Some models contain nested
fromPretrainedcalls inside their ownfromPretrainedmethod (hence now part of the newfromModelDirectorymethods). This PR does not attempt to refactor those, although this would be a good candidate for a subsequent PR, to ensure that no hub API interaction takes place with those models whenfromModelDirectoryis used.