Improvements to SSDP discovery and associated tests #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might help with #33 if their issue is the same timeout problem as mine. |
|
This might also fix #23 since one of the comments theorizes the issue is with the regular expression parsing. |
- minor version - python3
* Py3-compatibility changes Don't require six to check version * Version increment * Move examples * Adds tox.ini for multi-python testing * Update travis.yaml * Travis doesn't support Py3.7 yet. See travis-ci/travis-ci#9815
Discovery refactor Discovery tests Configure broadcast address for testing Allow testing against live camera Adds tox.ini for multi-python testing Update travis.yaml
TravisCI's Py3.4 environment already has six 1.10 installed.
|
Changed base branch to |
yep it is right. thanks! |
|
I merge it to develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into some errors using the SSDP discovery
ControlPoint()with my camera, so this is an attempt to clean up and improve the SSDP discovery logic.The two main changes in
pysony.pyare:breakout of the loop early in_listen_for_discover()-- I think this was the source of my bug, because it wasn't listening long enough to get the response from my camera.I've also added tests for SSDP discovery, including some dummy services to test against, and updated the README to include docs on running tests.
There's some minor overlap with #57, but I think the conflicts will be easy to resolve.