-
Notifications
You must be signed in to change notification settings - Fork 9
Leaf region will only trigger if the region exists #48
base: main
Are you sure you want to change the base?
Conversation
atlas_densities/densities/inhibitory_neuron_densities_optimization.py
Outdated
Show resolved
Hide resolved
… the original AtlasDensitiesError() message
mgeplf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failing tests are a result of:
pandas-dev/pandas#54954
So that will be fixed once the new version of pandas is released.
However, the following test is failing, and it should be looked at, I think:
| def test_error_on_sigmas_inconsistencies(): |
atlas_densities/densities/inhibitory_neuron_densities_optimization.py
Outdated
Show resolved
Hide resolved
atlas_densities/densities/inhibitory_neuron_densities_optimization.py
Outdated
Show resolved
Hide resolved
atlas_densities/densities/inhibitory_neuron_densities_optimization.py
Outdated
Show resolved
Hide resolved
atlas_densities/densities/inhibitory_neuron_densities_optimization.py
Outdated
Show resolved
Hide resolved
|
@cveraszto I have fixed the linting errors and such, but I will need you to update the test so that it makes sense for the changes that were made: |
atlas_densities/densities/inhibitory_neuron_densities_optimization.py
Outdated
Show resolved
Hide resolved
Ah, this is important! I will get to this! We can't have 0 values for deltas because that would mean the x_result can't be optimised, as there is no room for standard deviation around a cell count. |
…at the _sanity check function
This is a more generic solution to what was tested by Leo.
The issue with the same conditions will only trigger if the region actually exist.