Add websocket app-level ping/pong support #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
michael1011
requested changes
Mar 11, 2025
There was a problem hiding this comment.
Concept ACK
Tests are missing
And we should add this new ping/pong message (with some context regarding why it's needed) to https://github.com/BoltzExchange/boltz-backend/blob/master/docs/api-v2.md#websocket
|
michael1011
requested changes
Mar 11, 2025
There was a problem hiding this comment.
We use prettier for the Markdown files: https://github.com/BoltzExchange/boltz-backend/actions/runs/13794552658/job/38582904888?pr=850
npm run prettier:write fixes that CI fail
Good to merge afterwards
danielgranhao
force-pushed
the
websocket-app-level-ping
branch
from
a4af8eb to
eccef74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the browser (e.g. WASM clients), it isn't possible to manage WebSocket ping/pong frames directly.
This PR introduces app-level ping/pong messages to the WebSocket status stream so that clients can implement a consistent keep-alive mechanism that works across native and WASM builds.