Feat: 유저 닉네임 변경 api 구현 (#152)

* #151 - chore: 잘못된 패키지 명 수정 * #151 - feat: 유저의 이름을 변경하는 api 구현 * #151 - test: 유저 이름 변경 api 테스트 작성
BookitList · Feb 19, 2024 · 631937a · 631937a
1 parent f22e678
commit 631937a
Show file tree

Hide file tree

Showing 11 changed files with 86 additions and 8 deletions.
diff --git a/src/main/java/cotato/bookitlist/member/controller/MemberController.java b/src/main/java/cotato/bookitlist/member/controller/MemberController.java
@@ -1,9 +1,11 @@
 package cotato.bookitlist.member.controller;
 
 import cotato.bookitlist.config.security.jwt.AuthDetails;
+import cotato.bookitlist.member.dto.request.NameChangeRequest;
 import cotato.bookitlist.member.dto.response.MemberResponse;
 import cotato.bookitlist.member.dto.response.ProfileResponse;
 import cotato.bookitlist.member.service.MemberService;
+import jakarta.validation.Valid;
 import lombok.RequiredArgsConstructor;
 import org.springframework.http.ResponseEntity;
 import org.springframework.security.core.annotation.AuthenticationPrincipal;
@@ -46,4 +48,13 @@ public ResponseEntity<Void> changeProfileStatus(
         return ResponseEntity.ok().build();
     }
 
+    @PatchMapping("/name")
+    public ResponseEntity<Void> changeName(
+            @Valid @RequestBody NameChangeRequest nameChangeRequest,
+            @AuthenticationPrincipal AuthDetails details
+    ) {
+        memberService.changeName(nameChangeRequest.name(), details.getId());
+        return ResponseEntity.ok().build();
+    }
+
 }
diff --git a/src/main/java/cotato/bookitlist/member/domain/Member.java b/src/main/java/cotato/bookitlist/member/domain/Member.java
@@ -25,6 +25,7 @@ public class Member extends BaseEntity {
 
     private String email;
 
+    //TODO: name에 대한 제한을 만들어야한다.
     private String name;
 
     private String oauth2Id;
@@ -77,4 +78,8 @@ public void changeProfileStatus() {
             profileStatus = ProfileStatus.PRIVATE;
         }
     }
+
+    public void changeName(String name) {
+        this.name = name;
+    }
 }
diff --git a/src/main/java/cotato/bookitlist/member/dto/request/NameChangeRequest.java b/src/main/java/cotato/bookitlist/member/dto/request/NameChangeRequest.java
@@ -0,0 +1,9 @@
+package cotato.bookitlist.member.dto.request;
+
+import jakarta.validation.constraints.NotBlank;
+
+public record NameChangeRequest(
+        @NotBlank
+        String name
+) {
+}
diff --git a/src/main/java/cotato/bookitlist/member/service/MemberService.java b/src/main/java/cotato/bookitlist/member/service/MemberService.java
@@ -42,4 +42,10 @@ public void changeProfileStatus(Long memberId) {
         Member member = memberRepository.getReferenceById(memberId);
         member.changeProfileStatus();
     }
+
+    public void changeName(String name, Long memberId) {
+        Member member = memberRepository.getReferenceById(memberId);
+        member.changeName(name);
+    }
+
 }
diff --git a/src/main/java/cotato/bookitlist/post/controller/PostController.java b/src/main/java/cotato/bookitlist/post/controller/PostController.java
@@ -2,8 +2,8 @@
 
 import cotato.bookitlist.book.annotation.IsValidIsbn;
 import cotato.bookitlist.config.security.jwt.AuthDetails;
-import cotato.bookitlist.post.dto.requeset.PostRegisterRequest;
-import cotato.bookitlist.post.dto.requeset.PostUpdateRequest;
+import cotato.bookitlist.post.dto.request.PostRegisterRequest;
+import cotato.bookitlist.post.dto.request.PostUpdateRequest;
 import cotato.bookitlist.post.dto.response.PostCountResponse;
 import cotato.bookitlist.post.dto.response.PostListResponse;
 import cotato.bookitlist.post.dto.response.PostDetailResponse;

diff --git a/...ost/dto/requeset/PostRegisterRequest.java → ...post/dto/request/PostRegisterRequest.java b/...ost/dto/requeset/PostRegisterRequest.java → ...post/dto/request/PostRegisterRequest.java
@@ -1,4 +1,4 @@
-package cotato.bookitlist.post.dto.requeset;
+package cotato.bookitlist.post.dto.request;
 
 import cotato.bookitlist.book.annotation.IsValidIsbn;
 import cotato.bookitlist.post.domain.PostStatus;

diff --git a/.../post/dto/requeset/PostUpdateRequest.java → ...t/post/dto/request/PostUpdateRequest.java b/.../post/dto/requeset/PostUpdateRequest.java → ...t/post/dto/request/PostUpdateRequest.java
@@ -1,4 +1,4 @@
-package cotato.bookitlist.post.dto.requeset;
+package cotato.bookitlist.post.dto.request;
 
 import cotato.bookitlist.post.domain.PostStatus;
 import cotato.bookitlist.post.domain.PostTemplate;

diff --git a/src/main/java/cotato/bookitlist/post/service/PostService.java b/src/main/java/cotato/bookitlist/post/service/PostService.java
@@ -7,8 +7,8 @@
 import cotato.bookitlist.member.repository.MemberRepository;
 import cotato.bookitlist.post.domain.entity.Post;
 import cotato.bookitlist.post.dto.PostDetailDto;
-import cotato.bookitlist.post.dto.requeset.PostRegisterRequest;
-import cotato.bookitlist.post.dto.requeset.PostUpdateRequest;
+import cotato.bookitlist.post.dto.request.PostRegisterRequest;
+import cotato.bookitlist.post.dto.request.PostUpdateRequest;
 import cotato.bookitlist.post.dto.response.PostCountResponse;
 import cotato.bookitlist.post.dto.response.PostListResponse;
 import cotato.bookitlist.post.repository.PostRepository;

diff --git a/src/test/java/cotato/bookitlist/member/controller/MemberControllerTest.java b/src/test/java/cotato/bookitlist/member/controller/MemberControllerTest.java
@@ -2,6 +2,7 @@
 
 import com.fasterxml.jackson.databind.ObjectMapper;
 import cotato.bookitlist.annotation.WithCustomMockUser;
+import cotato.bookitlist.member.dto.request.NameChangeRequest;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -101,4 +102,33 @@ void givenLoginMember_whenChangingProfileStatus_thenChangeProfileStatus() throws
         ;
     }
 
+    @Test
+    @WithCustomMockUser
+    @DisplayName("유저 이름을 변경한다.")
+    void givenName_whenChangingName_thenChangeName() throws Exception{
+        //given
+        NameChangeRequest request = new NameChangeRequest("newName");
+
+        //when & then
+        mockMvc.perform(patch("/members/name")
+                        .content(objectMapper.writeValueAsBytes(request))
+                        .contentType(MediaType.APPLICATION_JSON))
+                .andExpect(status().isOk())
+        ;
+    }
+
+    @Test
+    @DisplayName("로그인 없이 유저 이름을 변경하면 에러를 반환한다.")
+    void givenNonLogin_whenChangingName_thenReturnErrorResponse() throws Exception {
+        //given
+        NameChangeRequest request = new NameChangeRequest("newName");
+
+        //when & then
+        mockMvc.perform(patch("/members/name")
+                        .content(objectMapper.writeValueAsBytes(request))
+                        .contentType(MediaType.APPLICATION_JSON))
+                .andExpect(status().isUnauthorized())
+        ;
+    }
+
 }
diff --git a/src/test/java/cotato/bookitlist/member/service/MemberServiceTest.java b/src/test/java/cotato/bookitlist/member/service/MemberServiceTest.java
@@ -41,5 +41,22 @@ void givenMemberId_whenChangingProfileStatus_thenChangeProfileStatus() throws Ex
         assertThat(member.getProfileStatus()).isEqualTo(ProfileStatus.PRIVATE);
     }
 
+    @Test
+    @DisplayName("유저의 이름을 변경한다.")
+    void givenName_whenChangingName_thenChangeName() throws Exception{
+        //given
+        Long memberId = 1L;
+        Member member = createMember(memberId);
+        String name = "newName";
+        given(memberRepository.getReferenceById(memberId)).willReturn(member);
+
+        //when
+        sut.changeName(name, memberId);
+
+        //then
+        then(memberRepository).should().getReferenceById(memberId);
+        assertThat(member.getName()).isEqualTo(name);
+    }
+
 
 }
diff --git a/src/test/java/cotato/bookitlist/post/controller/PostControllerTest.java b/src/test/java/cotato/bookitlist/post/controller/PostControllerTest.java
@@ -3,8 +3,8 @@
 import com.fasterxml.jackson.databind.ObjectMapper;
 import cotato.bookitlist.annotation.WithCustomMockUser;
 import cotato.bookitlist.post.domain.PostStatus;
-import cotato.bookitlist.post.dto.requeset.PostRegisterRequest;
-import cotato.bookitlist.post.dto.requeset.PostUpdateRequest;
+import cotato.bookitlist.post.dto.request.PostRegisterRequest;
+import cotato.bookitlist.post.dto.request.PostUpdateRequest;
 import jakarta.servlet.http.Cookie;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;