Update codeblock regex - fix multiple codeblocks #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove local `code_block` variable and rely on matched pattern to convert multiple code blocks. - Sometimes exported enex files do not contain the `-en-codeblock` tag. This uses the border style attribute to match the code block.
|
@rohjs has started working. Visit this issue on Issuehunt |
|
@rohjs has stopped working. Visit this issue on Issuehunt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for converting notes with multiple code blocks. Previously, only the last code block was being converted and thus repeated (see screenshots below). Also this updates the code block regex to make it a bit more reliable:
code_blockvariable and rely on matched pattern toconvert multiple code blocks.
-en-codeblocktag. Thisuses the border style attribute to match the code block.
Before
After