Add JSC/Bun test suite #2348
Open
Add JSC/Bun test suite #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borewit
requested changes
Feb 1, 2025
There was a problem hiding this comment.
This is great, I did not realize I could test the Safari engine this way. I want to apply this even further, and do Bum/JSC testing in the dependencies (peek-readable and strtok3) as well.
Please avoid using your default branch for PRs, that limits options for syncing your work and pushing corrections from my end.
I added some small comments, to avoid mixing different changes.
There was a problem hiding this comment.
Please don't upgrade dependencies with this PR.
There was a problem hiding this comment.
Good catch, but please put this fix in a separate PR
|
@jonluca, I think we overlooked a major issue, unlike in the Apple Safari browser, Bum does actually implement the BYOB stream reader. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds JSC as a test suite, to catch issues that would appear in Safari or Bun. It also fixes a minor issue with missing type imports.