Fix node-saml#392 Switching from jshint to eslint

 - Fix also Travis to run eslint instead of jshint
 - Upgrade eslint dep
 - fix lint violations

.travis.yml

@@ -5,4 +5,4 @@ node_js:
 
 script:
   - npm test
-  - ./node_modules/.bin/jshint lib
+  - ./node_modules/.bin/eslint lib

lib/passport-saml/saml.js

@@ -24,7 +24,7 @@ SAML.prototype.initialize = function (options) {
     options = {};
   }
 
-  if (options.hasOwnProperty('cert') && !options.cert) {
+  if (Object.prototype.hasOwnProperty.call(options, 'cert') && !options.cert) {
     throw new Error('Invalid property: cert must not be empty');
   }
 
@@ -591,7 +591,7 @@ SAML.prototype.validatePostResponse = function (container, callback) {
     doc = new xmldom.DOMParser({
     }).parseFromString(xml);
 
-    if (!doc.hasOwnProperty('documentElement'))
+    if (!Object.prototype.hasOwnProperty.call(doc, 'documentElement'))
       throw new Error('SAMLResponse is not valid base64-encoded XML');
 
     inResponseTo = xpath(doc, "/*[local-name()='Response']/@InResponseTo");
@@ -840,13 +840,13 @@ function validateSignatureForRedirect (urlString, signature, alg, cert) {
   function hasMatch (ourAlgo) {
     // The incoming algorithm is forwarded as a URL.
     // We trim everything before the last # get something we can compare to the Node.js list
-    const algFromURI = alg.toLowerCase().replace(/.*#(.*)$/,'$1')
-    return ourAlgo.toLowerCase() === algFromURI
+    const algFromURI = alg.toLowerCase().replace(/.*#(.*)$/,'$1');
+    return ourAlgo.toLowerCase() === algFromURI;
   }
   let i = crypto.getHashes().findIndex(hasMatch);
   let matchingAlgo;
   if (i > -1) {
-    matchingAlgo = crypto.getHashes()[i]
+    matchingAlgo = crypto.getHashes()[i];
   }
   else {
     throw alg + ' is not supported';
@@ -1038,7 +1038,7 @@ SAML.prototype.processValidlySignedAssertion = function(xml, samlResponseXml, in
 
       if (attributes) {
         attributes.forEach(function (attribute) {
-         if(!attribute.hasOwnProperty('AttributeValue')) {
+         if(!Object.prototype.hasOwnProperty.call(attribute, 'AttributeValue')) {
             // if attributes has no AttributeValue child, continue
             return;
           }

package.json

@@ -38,8 +38,8 @@
   },
   "devDependencies": {
     "body-parser": "^1.17.1",
+    "eslint": "^6.5.1",
     "express": "^4.16.2",
-    "jshint": "^2.10.1",
     "mocha": "^6.0.2",
     "passport": "0.4.x",
     "request": "^2.83.0",
@@ -50,7 +50,26 @@
     "node": ">= 8"
   },
   "scripts": {
-    "test": "mocha",
-    "jshint": "./node_modules/.bin/jshint lib"
+    "test": "npm run lint && mocha",
+    "lint": "./node_modules/.bin/eslint lib",
+    "lint:fix": "./node_modules/.bin/eslint --fix lib"
+  },
+  "eslintConfig": {
+    "env": {
+      "node": true,
+      "es6": false
+    },
+    "extends": "eslint:recommended",
+    "parserOptions": {
+      "ecmaVersion": 6
+    },
+    "rules": {
+      "no-undefined": "off",
+      "no-unused-vars": "off",
+      "semi": [
+        "error",
+        "always"
+      ]
+    }
   }
 }