Buildings can now (ideally) only last 2 hours max

[FightKnight441]

Buildings can now (ideally) only last 2 hours max. If supplies are still added at the building's max time, it will still consume the supplies., and hint to the player that this is happening.

[dijksterhuis]

This will probably need remoteExec-ing for the specific player, which means we need to pass the player object into the args for this script.

On player-hosted local development this will work because the server IS the player. But probably won't work on dedicated server.

I think. On phone so bit limited in what I can check easily.

Also, there's a notifications config here https://github.com/Bro-Nation/Paradigm/blob/development/client/configs/notifications.hpp

But that's for "client" functions and this is a "server" function.

Hmmm. I Need to think about this/have a look at the rest of the code path. I wonder if we can do the "too long, are your supplies" notification on whatever script calls this on the client?

Because the interaction overlay already shows how much time is left for supplies, so that value is already available to clients.

[FightKnight441]

I was copying how they did notifications for adding a crate.

https://github.com/Bro-Nation/Paradigm/blob/development/client/functions/basebuilding/fn_resupply_building_with_crate.sqf

if !(_nearbySupplies isEqualTo []) then { ["resupplybuilding", [_target, "CRATE"]] call para_c_fnc_call_on_server; } else { ["TaskFailed",["",localize "STR_vn_mf_nosupplydropnearby"]] call para_c_fnc_show_notification; };

Last line, they call a notification in a very similar way so, I think, it ought work, I do see what you mean though.

[dijksterhuis]

This will probably need remoteExec-ing for the specific player, which means we need to pass the player object into the args for this script.

Classic viewing a PR on my phone, I missed the fact _player is already in here as a variable. See REhandler note below for more info. What you'll need for this specific line (111) is

// executes the notification on the client of the specific player who has done the resupply
[["TaskFailed",["",localize "STR_para_build_maxtimereached"]]] remoteExecCall ["para_c_fnc_show_notification", _player];

It probably won't work on player hosted (local development), but it will work on dedicated server. See I need to refactor a thing because I was lazy note below

---

REhandler

Mostly a note so we're both aware of what's going on. At the top:

//THIS IS A REHANDLER FUNCTION
//It can only be called from rehandler, as it relies on having _player defined.

script --> fn_rehandler.sqf
_player is taken from the para_s_fnc_rehandler function's scope. layman's version -- para_s_fnc_rehandler calls this script and the _player variable still exists so this function can use it, one of those weird sqf things.

---

I need to refactor a thing because I was lazy

I'll need to add this in paradigm (it should really be here in paradigm/server/remoteExec anyway but I was being lazy :/ ): https://github.com/Bro-Nation/Mike-Force/blob/development/mission/functions/core/helpers/fn_rExecServerToGlobal_playerHost_or_dedicated.sqf

Server to global client remoteExec depending on whether execution is happening on a player hosted server or a dedicated server.

If you change the line to match the above, I'll do a PR after and switch it to that... or .... you can copy the vn_mf_fnc_rExecServerToGlobal_playerHost_or_dedicated function over to paradigm if you want some bonus points for saving me a job?

having both para_s_fnc_rExecServerToGlobal_playerHost_or_dedicated and vn_mf_fnc_rExecServerToGlobal_playerHost_or_dedicated should be fine for the time being (i'll fix the other references to the vn_mf one)

[dijksterhuis]

I was copying how they did notifications for adding a crate.

Last line, they call a notification in a very similar way so, I think, it ought work, I do see what you mean though.

Tally, seems like it's just one of those paradigm things. That's all fine then.

[FightKnight441]

Tally, seems like it's just one of those paradigm things. That's all fine then.

So it does or does not need to change from:

["TaskFailed",["",localize "STR_para_build_maxtimereached"]] call para_c_fnc_show_notification;

to:

[["TaskFailed",["",localize "STR_para_build_maxtimereached"]]] remoteExecCall ["para_c_fnc_show_notification", _player];

??

[dijksterhuis]

sorry, to clarify

Tally, seems like it's just one of those paradigm things. That's all fine then.

this was specifically about localize "STR_para_build_maxtimereached". just saying i didn't realise they used that method. Mike Force has the notification class name for the most part. Example here.

So it does need to change

yep, will need the remoteExec change.

[FightKnight441]

I think I see what you mean, but how does the notification on the resupply_with_crate/sandbag working then?

if !(_nearbySupplies isEqualTo []) then { ["resupplybuilding", [_target, "CRATE"]] call para_c_fnc_call_on_server; } else { ["TaskFailed",["",localize "STR_vn_mf_nosupplydropnearby"]] call para_c_fnc_show_notification; };

[dijksterhuis]

note to @dijksterhuis --- will need Bro-Nation/Mike-Force#399 for the notification string

[dijksterhuis]

split comment over two lines please cos it's quite long, we like to try and keep line length below 100 characters for readability and maintenance purposes

Example PR comment