Skip to content

Update uninstaller.nsi - remove non-working survey checkbox #4024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wesinator wants to merge 93 commits into from
Closed

Update uninstaller.nsi - remove non-working survey checkbox #4024

wesinator wants to merge 93 commits into from
+175,204 −4,463

Conversation

@wesinator
Copy link

@wesinator wesinator commented Dec 27, 2025

close #3657

MrAlex94 and others added 30 commits December 17, 2025 13:17
@MrAlex94
feat: add waterfox branding
ada64ab
@MrAlex94
feat: add .mozconfig files for build configurations
d6b22d7
@MrAlex94
feat: base moz.configure disable services and update app vendor
484149e
@MrAlex94
feat: add Waterfox specific preferences
cd407ed
@MrAlex94
fix: stop building pingsender executable
c23c8cc
@MrAlex94
feat: implement privileged extension support
7071f4e
@MrAlex94
feat(updater): part 1 - use Waterfox specific settings
1b2b2e7
@MrAlex94
feat(updater): part 2 - add update check disabling
d0d299e
@MrAlex94
feat: rename Firefox related references to their relevant counterparts
991acd4
@MrAlex94
feat: modify profile name
29f894f
@MrAlex94
feat(l10n): part 1 - add scaffolding
1b92ed2
@MrAlex94
feat(l10n): part 2 - add submodule
9e21d95
@MrAlex94
feat(l10n): part 3 - waterfox fluent files
29cfca1
@MrAlex94
ci: GitHub actions
bebbef2
@MrAlex94
feat: use version display for package version number
598758f
@MrAlex94
docs: update about:license
a0392e9
@MrAlex94
feat: add git commit to about:buildconfig page
dd29f4e 
(cherry picked from commit 0e34696)
@MrAlex94
docs: add build guide, README, contribution guide
23d74ce
@MrAlex94
feat: add addon version to about:addons list view and improve AddonOp…
b05f7b3 
…tions update method to handle missing updateInstall
@adamp01 @MrAlex94
docs: reword and add Waterfox domains to aboutDialog
52c34df
@MrAlex94
feat: add WaterfoxGlue to handle Waterfox specific code
258d284
@MrAlex94
feat: waterfox update migration code
0435a4c 
Run whenever there is an update and we need to modify settings
@MrAlex94
feat(theme): part 1 - add Waterfox theme foundation
18fd319
@MrAlex94
feat(theme): part 2 - add Lepton as the default theme
4796431
@MrAlex94
feat(theme): part 3 - register Lepton in WaterfoxGlue
cd4a4fa 
theme squash
@MrAlex94
feat: add scaffolding to load overlays into browser files
f0fe7c5
@MrAlex94
feat: load Waterfox overlays at window startup
f8a27f1
@MrAlex94
feat: allow customizations of default elements
800c2cc
@MrAlex94
feat: addon store compatibility
2cf668d
@MrAlex94
feat: Waterfox custom CSS
b120cfa
MrAlex94 and others added 23 commits December 19, 2025 13:32
@MrAlex94
fix: check for optimization flags
3753369
@MrAlex94
feat: implement automatic tab grouping
3ad7d7f
@MrAlex94
feat(sidebar): part 1 - tree vertical tabs v1.1
e483e97
@MrAlex94
feat(sidebar): part 2 - initialise in WaterfoxGlue
7f0425d
@MrAlex94
feat(sidebar): part 3 - tree vertical tabs gecko integration
854fb44
@MrAlex94
feat: use libz-rs-sys instead of zlib
b241819
@MrAlex94
feat: firefox import migrator
b49f0a0
@MrAlex94
feat: conditional compilation for Normandy
940acc3
@MrAlex94
feat(remote settings): disabled for search services
2af22ff
@MrAlex94
feat(remote settings): use query stripping parameters offline dump
1ac51af
@MrAlex94
feat(remote settings): use offline dumps where possible
b97c634
@MrAlex94
feat: disable speculative connection in address bar
5d13877
@MrAlex94
feat: enable custom wallpapers on about:newtab
4f62210
@MrAlex94
feat: add session restore checkbox when quitting the browser
3fe0e60
@MrAlex94
feat: native GTK menu integration for Unity global menu support
61ba3e4 
Source: https://aur.archlinux.org/packages/firefox-esr-globalmenu
@MrAlex94
feat: disable WebGPU release block checks and related platform
a83d23a 
restrictions
@MrAlex94
feat: Debian packaging files for Waterfox on Linux
d4bc4f5
@MrAlex94
backport: bug 1970223 - python 3.14 support
bbf9d5c
@MrAlex94
fix: cookie banner silence console error logs
469e240
@goodusername123 @MrAlex94
backport: Bug 1973125 [Linux/HDR] Don't pass nullptr GL context to Re…
4855af7 
…nderDMABUFTextureHost
@MrAlex94
refactor: test updated workflow
43bd22c
@wesinator
Update uninstaller.nsi - remove non-working survey checkbox
13823cc 
close #3657

Signed-off-by: Wes <[email protected]>
@wesinator
rm UN_SURVEY_CHECKBOX_LABEL
22529d1
@wesinator
Copy link
Author

wesinator commented Dec 31, 2025

@MrAlex94 looks like your force push caused a conflict in a totally unrelated part of the code?

@MrAlex94
Copy link
Collaborator

MrAlex94 commented Jan 8, 2026

Thanks for the PR.

The CONTRIBUTIONS file explains everything.

For the way Waterfox gets developed, this PR causes too many changes. I believe a simple commenting out of line 206 should be enough to stop the checkbox appearing at all: ;!define MUI_FINISHPAGE_SHOWREADME and will cause less conflicts in future rebases.

@MrAlex94
Copy link
Collaborator

MrAlex94 commented Jan 9, 2026

573d19e

@MrAlex94 MrAlex94 closed this Jan 9, 2026
@wesinator wesinator deleted the patch-1 branch January 9, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uninstall survey URL is no longer valid

6 participants

@wesinator @MrAlex94 @adamp01 @louie-github @goodusername123 @unknown5000