Added device level pin lock#2513
Open
kur00n3k0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This is a device-level implementation of a lock system by PIN. There's a module made in Javascript that does that, but it's not persistent and the UI is comletely different from the standard Bruce UI. This implementation keeps the original UI and adds persistance to the lock by adding variables to the bruce config file.
Types of Changes
This introduces a new feature.
Verification
The changes can be verified by configuring the lock status and PIN on the advanced configurations on Bruce. For testing the persistance, make the device deep sleep, shutdown or reboot. The lock may persist.
Testing
I tested it only on my Lilygo T-Embed CC1101 so I'm not sure if it's going to work on all devices.
Linked Issues
This PR is linked to a Issue I opened myself last year: #1966
User-Facing Change
This PR introduces a new configuration, letting the user to decide to configure or not a lock screen that can be unlocked by a PIN code.
Further Comments
This was only tested on the Lilygo T-Embed CC1101. Testing on other devices are welcome.