fix(HeavyButter): add MJS require() module whitelist and permission system (AV-004)#2521
Open
r13xr13 wants to merge 1 commit into
Open
fix(HeavyButter): add MJS require() module whitelist and permission system (AV-004)#2521r13xr13 wants to merge 1 commit into
r13xr13 wants to merge 1 commit into
Conversation
…ystem (AV-004)
- Add SAFE_MODULES and DANGEROUS_MODULES lists to globals_js.cpp
- native_require() now checks whitelist: safe modules always allowed,
dangerous modules require __allow() permission
- Add native_requireAllow() as __allow() JS global function
- Build hidden __module_registry in interpreter.cpp, remove dangerous
modules from global scope
- Update 12 shipped JS scripts to add __allow() calls before using
dangerous modules (storage, wifi, subghz, ir, serial, audio, gpio, badusb)
This closes the MJS sandbox escape vulnerability. Downloaded App Store
scripts that call require('storage') or require('wifi') without first
calling __allow() will receive a TypeError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes MJS sandbox escape.