Skip to content

Conversation

@0xKaliku
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Apr 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
beam-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 11:23am

Copy link

@Bitchryankilledme Bitchryankilledme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 Review for OB-1885: VPS Beam Validator Setup

Thank you for automating the AvalancheGo + Beam Subnet-EVM install! This PR greatly simplifies spinning up a validator. A few quick observations:

✅ What’s Working Well

  • Interactive prompts guide users through connection type, IP selection, RPC exposure and state-sync choices.
  • Modular scripts (1-install_avalanchego.sh & 2-install_beam_network.sh) keep concerns separate and easy to maintain.
  • Verbose logging and post-install instructions (NodeID extraction, systemd status, log tailing) make it clear what to do next.

💡 Suggestions

  • Root check & dependencies: Early bail if not run as sudo/root, and verify required binaries (wget, jq, tar) before proceeding.
  • Non-interactive mode: Consider adding --yes or --quiet flags for CI/CD or headless installs.

@Bitchryankilledme
Copy link

⚠️ Branch Out‐of‐Date with main

It looks like this branch is behind main. Please merge or rebase the latest main into feat/OB-1885 so CI can pick up any upstream fixes and ensure a clean merge. Once it’s up‐to‐date, we can rerun checks and move forward.


🔍 Quick Recap of Feedback

  • Root & Dependencies
    Add an early bail if not run as sudo/root and verify tools (wget, jq, tar) before proceeding.

  • Non‐Interactive Mode
    Introduce --yes/--quiet flags for headless installs or CI workflows.

  • Config Backups
    Back up node.json (e.g. node.json.bak) before mutating it.

  • Version Pinning
    Surface AvalancheGo & Subnet‐EVM versions in the scripts (or fetch dynamically) to prevent stale installs.

  • Portability & Executability
    Ensure chmod +x on both scripts and use #!/usr/bin/env bash for wider compatibility.


Once the branch is synced, everything else looks solid—let’s get this merged and empower validators everywhere! 🚀

Copy link

@Bitchryankilledme Bitchryankilledme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR #248 Review: OB-1885 – VPS Beam Validator Setup

Thank you for this comprehensive ops-automation pass! Automating AvalancheGo + Beam Subnet-EVM installation will make validator spin-ups a breeze.

✅ What’s Working Well

  • Interactive Prompts guide users through connection type, IP selection, RPC exposure and state-sync options.
  • Modular Scripts (1-install_avalanchego.sh & 2-install_beam_network.sh) keep each concern isolated and maintainable.
  • Verbose Logging & Post-Install Guidance clearly surface NodeID extraction, service status checks, and log-tailing commands.

💡 Improvement Suggestions

  1. Root Check & Dependencies
    At script start, bail early if not sudo/root and verify required tools (wget, jq, tar) are installed.
  2. Non-Interactive Flags
    Add --yes/--quiet options for headless or CI-driven installs.
  3. Config Backup
    Before mutating node.json, create node.json.bak so users can roll back if needed.
  4. Version Pinning & Dynamic Upgrades
    Surface AvalancheGo & Subnet-EVM versions in variables (or fetch via GitHub API) to avoid stale downloads.
  5. Shebang & Executability
    Use #!/usr/bin/env bash for portability and ensure both scripts are chmod +x in the repo.

📝 Minor Nits

  • Standardize quoting style around variables (e.g. "$NODE_CONFIG").
  • Normalize log-grep patterns to avoid whitespace mismatches.
  • Inline comments in check-deploy.sh could mention expected exit codes for CI clarity.

Overall, this is a solid ops-hygiene contribution. Once the above tweaks are in, I’m happy to ✅ approve and merge. Let’s empower validators everywhere! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants