refactor(cli): migrate from kingpin to cobra CLI framework #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dependencies
|
will reopen, need to test this locally |
joshichintan
changed the title
joshichintan
changed the title
joshichintan
force-pushed
the
main
branch
2 times, most recently
from
2a2bb98 to
c1fe576
Compare
|
Related: #173 Thanks for your contribution. Could you please have a look at tests, seems macOS builds are failing. |
BREAKING CHANGE: Migrates the CLI framework from kingpin to cobra for improved maintainability and better shell completion support. This change brings several improvements: - Enhanced shell completion with cobra's native completion engine - More intuitive command structure and flag handling - Better error messages and help text formatting - Improved maintainability with cobra's cleaner command organization All command functionality remains the same, but the underlying CLI framework has been completely replaced. Users should experience no breaking changes in command usage, though some internal behaviors may differ slightly. Commands migrated: - add, remove, list, rotate - exec, export, clear - login, proxy The migration maintains backward compatibility for all command-line arguments and flags while providing a more robust foundation for future enhancements.
|
@mbevc1 the add cmd test is failing due to no interactive keychain input received. I've two options,
would appreciate your guidance. |
|
Hi @joshichintan . Appreciate you looking into this, I'd probably say let's try to align with the current approach and go with 1. to get it up and running faster. Perhaps 2. could be a potential separate improvement PR? What did you have in mind in terms of adjusting CI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Migrates the CLI framework from kingpin to cobra for improved maintainability and better shell completion support.
This change brings several improvements:
All command functionality remains the same, but the underlying CLI framework has been completely replaced. Users should experience no breaking changes in command usage, though some internal behaviors may differ slightly.
Commands migrated:
The migration maintains backward compatibility for all command-line arguments and flags while providing a more robust foundation for future enhancements.