-
Notifications
You must be signed in to change notification settings - Fork 59
NEEDS TESTING: Syscall Signature (fresh ntdll load) #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
So this needs testing please as I don't have a current CAPE until i am back in office/have new home lab PC in a few weeks. The logic of this is that the Windows loader should take care of NTDLL. Loading a fresh NTDLL into itself from disk likely is then to begin parsing it for syscall instruction for doing that or to bypass hooking. Here are two samples that do this for testing each element: 1) AgentTesla https://capesandbox.com/analysis/46120/ This uses NTCreateFile on ntdll to load it and then NtReadFile to read it into memory. 2) LUMMA https://capesandbox.com/analysis/46359/ This uses NTCreateFile on ntdll to load it then maps in into its memory with NTCreateSection before changing the memory protections on it (likely to then patch it and remove hooks).
Summary of ChangesHello @kevross33, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Cuckoo signature designed to detect sophisticated malware techniques that involve loading a fresh copy of Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new Cuckoo signature to detect malware that loads a fresh copy of ntdll.dll from disk to bypass EDR hooks. The logic correctly identifies two common patterns involving NtReadFile and NtCreateSection/NtProtectVirtualMemory. However, the implementation contains several critical bugs, including syntax errors, incorrect use of operators, and unsafe handling of API arguments, which would prevent the signature from working correctly. I've provided detailed comments and suggestions to fix these issues.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
So this needs testing please as I don't have a current CAPE until i am back in office/have new home lab PC in a few weeks.
The logic of this is that the Windows loader should take care of NTDLL. Loading a fresh NTDLL into itself from disk likely is then to begin parsing it for syscall instruction for doing that or to bypass hooking.
Here are two samples that do this for testing each element:
This uses NTCreateFile on ntdll to load it and then NtReadFile to read it into memory.
This uses NTCreateFile on ntdll to load it then maps in into its memory with NTCreateSection before changing the memory protections on it (likely to then patch it and remove hooks).
There is another possible indirect syscall detection where ntdll is in memory where it starts parsing that for the sycall bytes. If I can find a sample doing that I will try and work out how to sig it if possible.