AWS SDK V2 w/ standard S3 Client#123
Open
eranrosenberg wants to merge 8 commits intoreleases/3.21.0from
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the S3 integration from AWS SDK v2 CRT (Common Runtime) client to the standard AWS SDK v2 S3 client. The change removes the dependency on aws-crt and updates the S3 client builder configuration accordingly.
- Removes AWS CRT dependency from Maven configuration
- Updates S3 client initialization to use standard builder instead of CRT builder
- Adjusts multipart upload configuration to use the standard SDK approach
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/hpc-server/pom.xml | Removed aws-crt dependency version property and dependency declaration |
| src/hpc-server/hpc-integration-impl/pom.xml | Removed aws-crt dependency and added hpc-domain-model dependency |
| src/hpc-server/hpc-integration-impl/src/main/resources/META-INF/spring/hpc-integration-beans-configuration.xml | Updated Spring bean class references to point to v2 implementations |
| src/hpc-server/hpc-integration-impl/src/main/java/gov/nih/nci/hpc/integration/s3/v2/impl/HpcS3Connection.java | Replaced CRT client builder with standard S3 client builder, removed CRT-specific configuration |
| src/hpc-server/hpc-integration-impl/src/main/java/gov/nih/nci/hpc/integration/s3/v2/impl/HpcDataTransferProxyImpl.java | Updated data transfer request ID generation to use completionFuture() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...c-integration-impl/src/main/java/gov/nih/nci/hpc/integration/s3/v2/impl/HpcS3Connection.java
Outdated
Show resolved
Hide resolved
...c-integration-impl/src/main/java/gov/nih/nci/hpc/integration/s3/v2/impl/HpcS3Connection.java
Outdated
Show resolved
Hide resolved
...c-integration-impl/src/main/java/gov/nih/nci/hpc/integration/s3/v2/impl/HpcS3Connection.java
Outdated
Show resolved
Hide resolved
...c-integration-impl/src/main/java/gov/nih/nci/hpc/integration/s3/v2/impl/HpcS3Connection.java
Outdated
Show resolved
Hide resolved
…hpc/integration/s3/v2/impl/HpcS3Connection.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...c-integration-impl/src/main/java/gov/nih/nci/hpc/integration/s3/v2/impl/HpcS3Connection.java
Outdated
Show resolved
Hide resolved
...c-integration-impl/src/main/java/gov/nih/nci/hpc/integration/s3/v2/impl/HpcS3Connection.java
Show resolved
Hide resolved
…hpc/integration/s3/v2/impl/HpcS3Connection.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
saradachintala
approved these changes
Dec 1, 2025
eranrosenberg
changed the base branch from
releases/3.20.0
to
releases/3.21.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing CRT S3 client