Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes crashes in the /search endpoint by adding handling for OpenSearch failures and adjusting default sort behavior.
Changes:
- Add try/catch around OpenSearch search execution and return a structured error.
- Harden request parsing in the dataset search controller (filters/search_text) and update the default sort field.
- Add a unit test + fixture for an OpenSearch error response.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| Utils/datasetFields.js | Introduces a default dataset sort field constant/export used by the controller. |
| Controllers/dataset.controllers.js | Validates request inputs, changes default sort field, and returns error responses when service reports OpenSearch errors. |
| Services/dataset.service.js | Wraps OpenSearch call with error handling and logs failures. |
| Services/dataset.service.test.js | Adds a test intended to cover OpenSearch error handling in the service. |
| Services/dataset.service.test.fixtures.js | Adds fixture representing an OpenSearch error payload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes crashes in original INS-1513 implementation
Change Details (Specifics)
Added handling for Opensearch errors in /search endpoint, as well as corresponding test
Related Ticket(s)
https://tracker.nci.nih.gov/browse/INS-1513