Skip to content

INS-1561#159

Merged
JoonLeeNIH merged 1 commit into3.3.0from
INS-1561
Mar 12, 2026
Merged

INS-1561#159
JoonLeeNIH merged 1 commit into3.3.0from
INS-1561

Conversation

@JoonLeeNIH
Copy link
Contributor

@JoonLeeNIH JoonLeeNIH commented Mar 12, 2026

Overview

Added new property to dataset details

Change Details (Specifics)

Added dataset_storage_distribution property to dataset details GraphQL query. Value of this property can be null.

Related Ticket(s)

https://tracker.nci.nih.gov/browse/INS-1561

Copilot AI review requested due to automatic review settings March 12, 2026 18:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new DatasetDetails field to the INS private ES GraphQL surface and wires it through the PrivateES dataset details fetcher so the value can be returned from OpenSearch.

Changes:

  • Added a new dataset_*_distribution field to the DatasetDetails GraphQL type.
  • Included the new field in PrivateESDataFetcher.datasetDetails() properties selection and field mapping.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/main/resources/graphql/ins-private-es.graphql Extends DatasetDetails GraphQL type with the new distribution field.
src/main/java/gov/nih/nci/bento_ri/model/PrivateESDataFetcher.java Ensures the new field is included in dataset details retrieval/mapping from OpenSearch.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@huuaho huuaho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoonLeeNIH JoonLeeNIH merged commit e1ee0e4 into 3.3.0 Mar 12, 2026
2 of 3 checks passed
@JoonLeeNIH JoonLeeNIH deleted the INS-1561 branch March 12, 2026 20:51
@amattu2 amattu2 added this to the 3.3.0 milestone Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants