Skip to content

DATASHARE-158 Government Usage Mobile Responsive Behavior#89

Merged
RuoxiZhang08 merged 1 commit into1.2.0from
DATASHARE-158
Mar 9, 2026
Merged

DATASHARE-158 Government Usage Mobile Responsive Behavior#89
RuoxiZhang08 merged 1 commit into1.2.0from
DATASHARE-158

Conversation

@amattu2
Copy link

@amattu2 amattu2 commented Mar 9, 2026

Overview

This PR fixes the missing mobile responsive behavior for the government usage banner that was lost during the MUI->tailwind migration.

Change Details (Specifics)

  • Fine-tune the dialog width to scale with the browser size
  • Adjust padding on the bulletpoints so the text line-breaks match CCDI Hub

Related Ticket(s)

DATASHARE-158

Copilot AI review requested due to automatic review settings March 9, 2026 17:11
@amattu2 amattu2 added this to the 1.2.0 milestone Mar 9, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves the Government Usage “OverlayWindow” modal layout to behave better on smaller viewports by constraining width/height and enabling internal scrolling while preserving the existing dialog structure.

Changes:

  • Add outer padding and convert the modal container to w-full with a max-w constraint for better mobile responsiveness.
  • Constrain modal height with max-h and prevent content overflow by moving scrolling into the body area (flex-1 min-h-0 overflow-auto).
  • Update the Vitest snapshot to reflect the new class names.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/components/OverlayWindow/index.tsx Adjusts modal sizing/overflow styles for improved mobile responsiveness.
src/components/OverlayWindow/__snapshots__/index.test.tsx.snap Updates snapshot output to match the updated modal markup/classes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@amattu2 amattu2 requested a review from RuoxiZhang08 March 9, 2026 17:15
@RuoxiZhang08 RuoxiZhang08 merged commit f5d05a1 into 1.2.0 Mar 9, 2026
7 checks passed
@RuoxiZhang08 RuoxiZhang08 deleted the DATASHARE-158 branch March 9, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants