Skip to content

[FEAT] Add module decoder_xds to lib_ccxr #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vats004
Copy link
Contributor

@vats004 vats004 commented Mar 26, 2025

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

This PR migrates /src/lib_ccx/ccx_decoders_xds.c to rust.
These changes have been made-

  1. Pure rust equivalent functions in /src/rust/lib_ccxr/src/decoder_xds/functions_xds.rs
  2. Required datatypes in /src/rust/lib_ccxr/src/decoder_xds/structs_xds.rs
  3. C-compatible rust functions/exports in src/rust/src/libccxr_exports/xds_exports.rs
  4. Declaration and use of written rust functions in /src/lib_ccx/ccx_decoders_xds.c
  5. Added some #[repr(C)]s in existing structs

To-do:

  • Unit tests

@vats004 vats004 force-pushed the xds-migration branch 2 times, most recently from b5cb634 to 029d630 Compare March 29, 2025 13:44
@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 9e2a594...:

Report Name Tests Passed
Broken 0/13
CEA-708 0/14
DVB 0/7
DVD 0/3
DVR-MS 0/2
General 0/27
Hauppage 0/3
MP4 0/3
NoCC 0/10
Options 0/86
Teletext 0/21
WTV 0/13
XDS 0/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:


Check the result page for more info.

@vats004 vats004 changed the title [FEAT] Add module decoder_xds to lib_ccxr [FEAT] WIP module decoder_xds to lib_ccxr Apr 21, 2025
@vats004 vats004 changed the title [FEAT] WIP module decoder_xds to lib_ccxr [FEAT] Add module decoder_xds to lib_ccxr Apr 21, 2025
@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 888ffa4...:

Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 7/7
DVD 3/3
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 85/86
Teletext 21/21
WTV 13/13
XDS 34/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants