Skip to content

[IMPROVEMENT] Refactor and optimize Dockerfile #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 27, 2025

Conversation

AhmedYasserrr
Copy link
Contributor

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Changes:

  • Replaced cd commands with WORKDIR instructions to improve clarity and follow Docker best practices.
  • Removed the unused RUN export for LIB_CLANG_PATH, which only affected a single build layer (since export does not persist between Docker layers); the library is automatically detected during build.
  • Parallelized GPAC build using make -j$(nproc), significantly reducing build time.
  • Removed redundant CMD instruction since ENTRYPOINT already defines the execution command.

This PR improves Dockerfile structure, reduces build time, and eliminates unnecessary instructions for a cleaner and more maintainable setup.

Sorry, something went wrong.

AhmedYasserrr and others added 4 commits March 30, 2025 09:49

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
- Replaced cd with WORKDIR for clarity and Docker best practices.
- Removed unused LIB_CLANG_PATH export, as it only affected a single build layer; the library is automatically detected during build.
- Parallelized the GPAC build using make -j$(nproc).
- Removed redundant CMD instruction, as ENTRYPOINT already defines the container's execution command.
@cfsmp3 cfsmp3 requested review from cfsmp3 and Copilot April 27, 2025 18:29
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors and optimizes the Dockerfile to improve clarity, reduce build time, and remove unnecessary instructions.

  • Replaces cd commands with WORKDIR
  • Removes an unused RUN export instruction
  • Parallelizes the GPAC build with make -j$(nproc) and removes a redundant CMD instruction
Files not reviewed (1)
  • docker/dockerfile: Language not supported

@cfsmp3 cfsmp3 merged commit 17247da into CCExtractor:master Apr 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants