- 
                Notifications
    
You must be signed in to change notification settings  - Fork 482
 
[FIX] add mac-ocr-hardsubx workflow & ffmpeg variants support #1745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
      
        
          +463
        
        
          −120
        
        
          
        
      
    
  
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            12 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      4e96e5f
              
                Fix critical hardsubx OCR bugs affecting accuracy and stability
              
              
                prateekmedia 469debd
              
                Fix CLI parameters and add platform-specific paths for OCR
              
              
                prateekmedia 660d524
              
                Configure rsmpeg for platform-specific FFmpeg versions
              
              
                prateekmedia 828a9cf
              
                Update build scripts to support FFmpeg version selection
              
              
                prateekmedia b0529d8
              
                Update CI workflows and Windows configuration
              
              
                prateekmedia 7d94a15
              
                Update COMPILATION.md with FFmpeg version configuration
              
              
                prateekmedia b94301d
              
                fix: update version of rsmpeg
              
              
                prateekmedia 1399b2a
              
                fix: revert to ffmpeg6 for windows
              
              
                prateekmedia 2624d8d
              
                fix: toml
              
              
                prateekmedia 0787279
              
                Merge remote-tracking branch 'origin/master' into hardsubx_patch
              
              
                prateekmedia 6b5f8b0
              
                Restore hardsubx files to origin master
              
              
                prateekmedia 924ef0d
              
                Update Windows FFmpeg default in docs
              
              
                prateekmedia File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still support these? If not, we can probably remove them to keep the code base clean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing changed on that part from past, so I do think we support it.