Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][URGENT] Check for platform while fetching last test on master #874

Merged

Conversation

Tarun-Arora
Copy link
Contributor

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used the project.
  • I have used the project briefly.
  • I have used the project extensively, but have not contributed previously.
  • I am an active contributor to the project.

This PR is a fix to #869, also check the platform name while fetching the last completed master test.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0a0c07c) 86.62% compared to head (24aaf14) 86.62%.

❗ Current head 24aaf14 differs from pull request most recent head 1845a11. Consider uploading reports for the commit 1845a11 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #874   +/-   ##
=======================================
  Coverage   86.62%   86.62%           
=======================================
  Files          35       35           
  Lines        3678     3678           
  Branches      744      744           
=======================================
  Hits         3186     3186           
  Misses        354      354           
  Partials      138      138           
Flag Coverage Δ
unittests 86.62% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
mod_ci/controllers.py 82.59% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tarun-Arora Tarun-Arora changed the title [FIX] Check for platform while fetching last test on master [FIX][URGENT] Check for platform while fetching last test on master Sep 12, 2023
@Tarun-Arora Tarun-Arora marked this pull request as draft September 12, 2023 14:44
@Tarun-Arora Tarun-Arora marked this pull request as ready for review September 12, 2023 14:55
@Tarun-Arora
Copy link
Contributor Author

I force pushed just to retrigger GH actions failing due to #825

@canihavesomecoffee canihavesomecoffee merged commit 8acd63a into CCExtractor:master Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants