Fix: One-time alarms remain enabled after ringing #782
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When setting an alarm with repeat = never (one-time alarm), the alarm remains enabled after it rings instead of being automatically disabled. This causes the alarm to potentially ring again on subsequent days, which is not the expected behavior for a one-time alarm.
Proposed Changes
Consolidated the one-time alarm handling logic in
alarm_ring_controller.dart
:onClose
methodRemoved duplicate one-time alarm handling from
splash_screen_controller.dart
:Fixes #781
Screenshots
WhatsApp.Video.2025-03-24.at.17.45.14.mp4
Checklist