Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve snooze duration list ux #792

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

xSkkarf
Copy link
Contributor

@xSkkarf xSkkarf commented Mar 27, 2025

Description

The snooze duration NumberPicker starts from 1 (minute) which cannot be selected from first attempt (as shown in first video). Also, user cannot disable snooze after setting it because the minimum choice is 1.

Proposed Changes

Make the list start from 0 (off state) to to add snooze disabling functionality. Also, this is better ux-wise as compared to 1 as initial state which does not get selected even after pressing Done

Videos

Before:

before.mp4

After:

after.mp4

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

@xSkkarf
Copy link
Contributor Author

xSkkarf commented Mar 27, 2025

@MarkisDev can you take a look at this?

@rakshitjain23
Copy link

@xSkkarf can u tell me like i am also working on a feature but issue is with gradle build apply script these issues are getting me.

@xSkkarf
Copy link
Contributor Author

xSkkarf commented Mar 28, 2025

@rakshitjain23 If I got you right, this is addressed here. It's related to flutter, java, and android studio versions.

@rakshitjain23
Copy link

@xSkkarf Thanks bro from there my issue got resolve and also i added that feature and this is my first open-source contribution also.

@MarkisDev MarkisDev merged commit 98b12fe into CCExtractor:main Mar 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants