Skip to content

Support paging of merge candidate list#357

Merged
mpeels merged 2 commits intomainfrom
CND-242-support-paging
Apr 23, 2025
Merged

Support paging of merge candidate list#357
mpeels merged 2 commits intomainfrom
CND-242-support-paging

Conversation

@mpeels
Copy link
Copy Markdown
Contributor

@mpeels mpeels commented Apr 22, 2025

Notes

  1. Updates response from merge list API to include paging information
  2. Updates merge controller to have base path of /merge

JIRA

Checklist

Types of changes

What types of changes does this PR introduces?

  • Bugfix
  • New feature
  • Breaking change

Testing

  • Does this PR has >90% code coverage?
  • Is the screenshot attached for code coverage?
  • Does the gradle build pass in your local?
  • Is the gradle build logs attached?

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@snehaasjournal snehaasjournal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. 🥇

My only nit-pick suggestion would be to DRY up the methods markMergedRecordAsMerge, markNonActiveRecordAsNoMerge, and markSingleRemainingRecordAsNoMergeIfExists in updateMergeStatusForPatients() in MergeGroupHandler.java since I see they all call DB updates with overlapping parameters. Not a blocker and it's not a part of this PR.

@mpeels mpeels merged commit 8078a17 into main Apr 23, 2025
3 checks passed
@mpeels mpeels deleted the CND-242-support-paging branch April 23, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants