Add API to retrieve merge candidates by patient ID.#358
Merged
sizatenquizit merged 7 commits intomainfrom Apr 23, 2025
Merged
Conversation
mpeels
requested changes
Apr 23, 2025
Comment on lines
+26
to
+34
| private static final Map<String, String> RACE_MAP = Map.ofEntries( | ||
| Map.entry("1002-5", "AMERICAN_INDIAN"), | ||
| Map.entry("2028-9", "ASIAN"), | ||
| Map.entry("2054-5", "BLACK"), | ||
| Map.entry("2076-8", "HAWAIIAN"), | ||
| Map.entry("2106-3", "WHITE"), | ||
| Map.entry("2131-1", "OTHER"), | ||
| Map.entry("U", "UNKNOWN") | ||
| ); |
Contributor
There was a problem hiding this comment.
Possible issue: These values come from the code_value_general table. They are SYS controlled values so they shouldn't change frequently (user can't edit them through UI), but it is still possible for them to change.
I'm fine with caching these values but it would be better to pull them from the database on startup.
If we want to keep it this way for now, I'm ok with it. We would just need to put a story in the backlog to address it in the future.
Comment on lines
+69
to
+81
| public static final List<String> SUPPORTED_IDENTIFIERS = Arrays.asList( | ||
| "AC", "ACSN", "AIN", "AM", "AMA", "AN", "ANC", "AND", "ANON", "ANT", "APRN", "ASID", "BA", "BC", | ||
| "BCFN", "BCT", "BR", "BRN", "BSNR", "CAII", "CC", "CONM", "CY", "CZ", "DC", "DCFN", "DDS", "DEA", | ||
| "DFN", "DI", "DL", "DN", "DO", "DP", "DPM", "DR", "DS", "DSG", "EI", "EN", "ESN", "FDR", "FDRFN", | ||
| "FGN", "FI", "FILL", "GI", "GIN", "GL", "GN", "HC", "IND", "IRISTEM", "JHN", "LACSN", "LANR", "LI", | ||
| "LN", "LR", "MA", "MB", "MC", "MCD", "MCN", "MCR", "MCT", "MD", "MI", "MR", "MRT", "MS", "NBSNR", | ||
| "NCT", "NE", "NH", "NI", "NII", "NIIP", "NP", "NPI", "OBI", "OD", "PA", "PC", "PCN", "PE", "PEN", | ||
| "PGN", "PHC", "PHE", "PHO", "PI", "PIN", "PLAC", "PN", "PNT", "PPIN", "PPN", "PRC", "PRN", "PT", | ||
| "QA", "RI", "RN", "RPH", "RR", "RRI", "RRP", "SAMN", "SB", "SID", "SL", "SN", "SNBSN", "SNO", "SP", | ||
| "SR", "SRX", "SS", "STN", "TAX", "TN", "TPR", "TRL", "U", "UDI", "UPIN", "USID", "VN", "VP", "VS", | ||
| "WC", "WCN", "WP", "XV", "XX" | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
Possible Issue: Its possible that these could be different for different STLTs or change over time.
See RACE_MAP comment for more info.
…://github.com/CDCgov/NEDSS-DataIngestion into CND-269-API-Retrieve-Merge-Candidates-details
|
mpeels
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA
https://cdc-nbs.atlassian.net/browse/CND-269