-
Notifications
You must be signed in to change notification settings - Fork 5
CNDE-3045 : updated format for vaccination #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
liquibase-service/src/main/resources/db/003-odse/routines/027-sp_vaccination_event-001.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f_vaccination also needs to be updated
Edit: dbo.INVESTIGATION inv1 with (nolock) on inv1.CASE_UID = nc.PHC_UID;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The postprocessing stored procedure and any other process that references this column also needs to be updated to reflect this change.
|
Please add test coverage for new lines of code. |
|
| @Column(name="ORGANIZATION_UID") | ||
| private Long organizationUid; | ||
|
|
||
| @Column(name="PHC_UID") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
The update functionality looks good for multiple investigations. Once the delete logic is confirmed, this PR should be good to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality works as expected.
Deletes will be reviewed separately.



Notes
updated format for sp_vaccination_event
JIRA
Checklist
Types of changes
What types of changes does this PR introduces?
Testing
gradle buildpass in your local?gradle buildlogs attached?