Skip to content

Conversation

@jayasudhasundaram
Copy link
Collaborator

Notes

updated format for sp_vaccination_event

JIRA

Checklist

Types of changes

What types of changes does this PR introduces?

  • Bugfix
  • New feature
  • Breaking change

Testing

  • Does this PR has >90% code coverage?
  • Is the screenshot attached for code coverage?
  • Does the gradle build pass in your local?
  • Is the gradle build logs attached?

Copy link
Contributor

@upasanapattnaik-eq upasanapattnaik-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f_vaccination also needs to be updated
Edit: dbo.INVESTIGATION inv1 with (nolock) on inv1.CASE_UID = nc.PHC_UID;

Copy link
Contributor

@upasanapattnaik-eq upasanapattnaik-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The postprocessing stored procedure and any other process that references this column also needs to be updated to reflect this change.

@sveselev
Copy link
Contributor

Please add test coverage for new lines of code.

@sonarqubecloud
Copy link

@Column(name="ORGANIZATION_UID")
private Long organizationUid;

@Column(name="PHC_UID")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@upasanapattnaik-eq
Copy link
Contributor

The update functionality looks good for multiple investigations. Once the delete logic is confirmed, this PR should be good to merge.

Copy link
Contributor

@upasanapattnaik-eq upasanapattnaik-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works as expected.
Deletes will be reviewed separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants