Skip to content

Navigation Menu

Appearance settings

GitHub Copilot
Write better code with AI

GitHub Spark New
Build and deploy intelligent apps

GitHub Models New
Manage and compare prompts

GitHub Advanced Security
Find and fix vulnerabilities

Actions
Automate any workflow
Codespaces
Instant dev environments

Issues
Plan and track work

Code Review
Manage code changes

Discussions
Collaborate outside of code

Code Search
Find more, search less
Explore

Why GitHub

Documentation

GitHub Skills

Blog
Integrations

GitHub Marketplace
View all features
By company size

Enterprises

Small and medium teams

Startups

Nonprofits
By use case

DevSecOps

DevOps

CI/CD

View all use cases
By industry

Healthcare

Financial services

Manufacturing

Government

View all industries
View all solutions
Topics

AI

DevOps

Security

Software Development

View all
Explore

Learning Pathways

Events & Webinars

Ebooks & Whitepapers

Customer Stories

Partners

Executive Insights
GitHub Sponsors
Fund open source developers
The ReadME Project
GitHub community articles
Repositories

Topics

Trending

Collections
Enterprise platform
AI-powered developer platform
Available add-ons

GitHub Advanced Security
Enterprise-grade security features

Copilot for business
Enterprise-grade AI features

Premium Support
Enterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

CDCgov / NEDSS-DataReporting Public

generated from CDCgov/template

Notifications You must be signed in to change notification settings
Fork 5
Star 2

Code
Issues
Pull requests 4
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

CNDE-2936: Data Validation queries #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

johneipe merged 10 commits into main from CNDE-2936

Sep 8, 2025

Merged

CNDE-2936: Data Validation queries #594

johneipe merged 10 commits into main from CNDE-2936

Sep 8, 2025

+2,537 −0

Conversation 15 Commits 10 Checks 0 Files changed 2

Conversation

Copy link

Collaborator

johneipe commented Aug 28, 2025

Notes

This adds the validation queries into the repo. The details are provided in
https://cdc-nbs.atlassian.net/wiki/spaces/NM/pages/1126236161/Missing+or+Orphaned+data+validation+scripts+for+data+warehouse

JIRA

Related story: CNDE-2936

Checklist

PR focuses on a single story.
New unit tests added and ensured they pass.
Service has been tested in local and it works as expected.
Documentation has been updated for this code change (if needed).
Code follows the Java Coding Conventions (https://www.oracle.com/java/technologies/javase/codeconventions-programmingpractices.html).

Types of changes

What types of changes does this PR introduces?

Bugfix
New feature
Breaking change

Testing

Does this PR has >90% code coverage?
Is the screenshot attached for code coverage?
Does the gradle build pass in your local?
Is the gradle build logs attached?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

johneipe requested a review from upasanapattnaik-eq

August 29, 2025 13:30

johneipe force-pushed the CNDE-2936 branch from c55ca81 to 28eafd7 Compare

August 29, 2025 18:31

johneipe requested a review from rseshadri99

August 29, 2025 18:39

upasanapattnaik-eq reviewed

View reviewed changes

liquibase-service/src/main/resources/stlt/data_validaiton/001-job_validation_config.sql Show resolved Hide resolved

Uh oh!

There was an error while loading. Please reload this page.

upasanapattnaik-eq reviewed

View reviewed changes

liquibase-service/src/main/resources/stlt/data_validaiton/001-job_validation_config.sql Show resolved Hide resolved

Uh oh!

There was an error while loading. Please reload this page.

upasanapattnaik-eq reviewed

View reviewed changes

liquibase-service/src/main/resources/stlt/data_validaiton/001-job_validation_config.sql Outdated Show resolved Hide resolved

Uh oh!

There was an error while loading. Please reload this page.

upasanapattnaik-eq reviewed

View reviewed changes

liquibase-service/src/main/resources/stlt/data_validaiton/002-sp_run_validation.sql Outdated Show resolved Hide resolved

Uh oh!

There was an error while loading. Please reload this page.

johneipe marked this pull request as ready for review

August 29, 2025 21:11

upasanapattnaik-eq reviewed

View reviewed changes

liquibase-service/src/main/resources/stlt/data_validaiton/002-sp_run_validation.sql Outdated Show resolved Hide resolved

Uh oh!

There was an error while loading. Please reload this page.

upasanapattnaik-eq reviewed

View reviewed changes

liquibase-service/src/main/resources/stlt/data_validaiton/002-sp_run_validation.sql Outdated Show resolved Hide resolved

Uh oh!

There was an error while loading. Please reload this page.

johneipe force-pushed the CNDE-2936 branch from 38f606c to dea65d6 Compare

September 3, 2025 13:51

johneipe added 7 commits

September 4, 2025 10:19


          Data Validation queries

44ed995


          Updated

0ed4665


          Updated

f09845e

Fix

710a6e1

Fix

bcd3c73


          Updated


          Updated

c6591b8

johneipe force-pushed the CNDE-2936 branch from dea65d6 to c6591b8 Compare

September 4, 2025 15:19


          Update

3f31489

johneipe requested review from joshua-mills-cdw and jayasudhasundaram

September 4, 2025 19:23

joshua-mills-cdw reviewed

View reviewed changes

liquibase-service/src/main/resources/stlt/data_validaiton/002-sp_run_validation.sql Show resolved Hide resolved

Uh oh!

There was an error while loading. Please reload this page.

joshua-mills-cdw reviewed

View reviewed changes

liquibase-service/src/main/resources/stlt/data_validaiton/002-sp_run_validation.sql Outdated Show resolved Hide resolved

Uh oh!

There was an error while loading. Please reload this page.

joshua-mills-cdw reviewed

View reviewed changes

liquibase-service/src/main/resources/stlt/data_validaiton/002-sp_run_validation.sql Show resolved Hide resolved

Uh oh!

There was an error while loading. Please reload this page.


          Updated

ae8a6c3

joshua-mills-cdw approved these changes

View reviewed changes

Copy link

Collaborator

joshua-mills-cdw left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Update

c04a896

upasanapattnaik-eq approved these changes

View reviewed changes

Copy link

Collaborator

upasanapattnaik-eq left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

johneipe merged commit 51f39bb into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

upasanapattnaik-eq upasanapattnaik-eq approved these changes

joshua-mills-cdw joshua-mills-cdw approved these changes

rseshadri99 Awaiting requested review from rseshadri99

jayasudhasundaram Awaiting requested review from jayasudhasundaram

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.