Skip to content

add support for Feather Boards #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/CSE_RS485.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
//===================================================================================//

// Version: 1.0.13
// Last modified: +05:30 22:26:25 PM 06-07-2024, Saturday
// Last modified: +05:30 21:11:21 PM 30-06-2024, Sunday
// Source: https://github.com/CIRCUITSTATE/CSE_ArduinoRS485

//===================================================================================//
Expand Down Expand Up @@ -56,11 +56,13 @@

// Define default values
#define _HAVE_HWSERIAL1
#define _HAVE_HWSERIAL2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a second hardware serial port as default will break compatibility for boards like ESP8266. This is already handled in a better way in the latest changes.


// Check for specific architectures and boards
#if defined(ARDUINO_AVR_UNO) || defined(ARDUINO_AVR_NANO)
// Arduino Uno and Nano have only one hardware serial port
#define _HAVE_HWSERIAL1
#undef _HAVE_HWSERIAL2
#elif defined(ARDUINO_AVR_MEGA2560)
// Arduino Mega has four hardware serial ports
#define _HAVE_HWSERIAL1
Expand All @@ -72,10 +74,6 @@
#define _HAVE_HWSERIAL1
#define _HAVE_HWSERIAL2
#define _HAVE_HWSERIAL3
#else
// Else assume that the board has at least two hardware serial ports
#define _HAVE_HWSERIAL1
#define _HAVE_HWSERIAL2
#endif

// Define a flag to include SoftwareSerial if no additional UARTs are available
Expand Down