Use VIN instead of name for uniq keys #324
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With multiple cars, HomeAssistant complains that all cars are using the same uniq_id for entities. This results in most of them being disabled. After looking at the code, it's obvious that only ones working were buttons and switches. For those ha-porscheconnect uses VIN as part of the uniq_id, while for others it's using name.
This patch changes uniq_ids for image, binary_sensor, lock, number and sensor entities to VIN.
This patch does not handle the upgrade procedure, so just applying it will result in double entries in existing deployments. I'm not sure what's the best way to rename existing entries?