BB2-4099 Update pre-prod deploy for redesign/staging #425
Conversation
| rsync -av -e "ssh -oHostKeyAlgorithms=+ssh-dss -oStrictHostKeyChecking=no -i ${AKAMAI_SCP_SSH_KEY}" ./dist/static-main.css ${AKAMAI_SSH_USER}@bluebuttoncms.rsync.upload.akamai.com:${UPLOAD_LOCATION}assets/css/ | ||
| rsync -av -e "ssh -oHostKeyAlgorithms=+ssh-dss -oStrictHostKeyChecking=no -i ${AKAMAI_SCP_SSH_KEY}" ./dist/ ${AKAMAI_SSH_USER}@bluebuttoncms.rsync.upload.akamai.com:${UPLOAD_LOCATION} --delete | ||
| """ | ||
| } |
There was a problem hiding this comment.
Looks like we lose the ability to deploy CSS here, is that expected/impactful? Other than that, everything looks good, just want to make sure I understand the impact of taking CSS stuff out here.
There was a problem hiding this comment.
Unless there is another external resource consuming that CSS, it shouldn't be an issue. The site bundles all the static assets it needs inside ./dist/, so there's no need to manually include anything else
There was a problem hiding this comment.
Looks like this is meant for pulling in CSS from the CSS repo: https://github.com/CMSgov/bluebutton-site-static/pull/425/files/0e8322630371fe95380c72760e62110eaf58e705#diff-67342a76a94d7dd761a7996be3137839eb4f22c3915b904c942ed61bfac63f61L88-L96
We don't reference that CSS in the new site, so fine to drop this step
There was a problem hiding this comment.
Tagged in @clewellyn-nava to hopefully assess whether or not the server depends on this CSS deploy step, but I believe most of what we look for from the server side is in s3 and not in netstorage, so this should be okay, and if anything, we should have this as part of the server deployment, not tied to this new static site deploy. I'll go ahead and approve, we can always revert or make a new pipeline for that piece if needed later.
JIRA Ticket:
BB2-4099
What Does This PR Do?
Update pre-prod deploy script to pull in and deploy
uswds-redesignso we can see the redesign on stagingWhat Should Reviewers Watch For?
uswds-redesignbranch is cheked out correctlyValidation
Successful deploy https://ci.backends.cms.gov/non-oc/job/Blue%20Button/job/DEPLOY%20-%20Static%20Site%20(Akamai)/view/change-requests/job/PR-425/
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following: