Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brandon/bb2 3792 401 errors #1310

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

bwang-icf
Copy link
Contributor

JIRA Ticket:
[BB2-3792]https://jira.cms.gov/browse/BB2-3792

What Does This PR Do?

Fixes the issues with test client running into auth flow issues that are solved by refreshing. Added a retry mechanism around the bits of code that interfaced with SLS.

What Should Reviewers Watch For?

Any instance of the connection issues resurfacing

If you're reviewing this PR, please check for these things in particular:

Any other cleaner ways of having this code or other ideas to handle this more comprehensively would be appreciated. Currently, this just is around a few specific instances, so being able to handle this generally might be worth investigating.

Validation

Proof of retry with a then successful connection

Screenshot 2025-03-31 at 4 40 03 PM

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

@bwang-icf bwang-icf requested a review from jimmyfagan April 1, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant