Testing

.devcontainer/devcontainer.json

@@ -9,10 +9,10 @@
 		"ghcr.io/devcontainers/features/docker-in-docker:2": {}
 	},
 
-	"runArgs": ["--gpus=all"],
-	"hostRequirements": {
-		"gpu": true
-	},
+	// "runArgs": ["--gpus=all"],
+	// "hostRequirements": {
+	// 	"gpu": true
+	// },
 
 	"postCreateCommand": "sudo apt-get update && sudo apt-get install -y zstd && curl -fsSL https://ollama.com/install.sh | sh && uv sync && ollama serve & sleep 5 && ollama pull qwen3:0.6b",
 	"postStartCommand": "ollama serve &"

test/unit/test_translator.py

@@ -55,5 +55,277 @@ def test_llm_missing_text_fallback(monkeypatch):
     original_content = "Bonjour"
     is_english, translated_content = translator.translate(original_content)
 
+    assert is_english is True
+    assert translated_content == original_content
+
+def test_english_text(monkeypatch):
+    mock_response = {
+        "message": {
+            "content": "ENGLISH: Yes\nTEXT: Hello world"
+        }
+    }
+
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    is_english, translated_content = translator.translate("Hello world")
+
+    assert is_english is True
+    assert translated_content == "Hello world"
+
+
+def test_french_text(monkeypatch):
+    mock_response = {
+        "message": {
+            "content": "ENGLISH: No\nTEXT: Good evening"
+        }
+    }
+
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    is_english, translated_content = translator.translate("Bonsoir")
+
+    assert is_english is False
+    assert translated_content == "Good evening"
+
+
+def test_response_with_think_artifacts(monkeypatch):
+    mock_response = {
+        "message": {
+            "content": "/think I need to analyze this text\nENGLISH: No\nTEXT: Hello there"
+        }
+    }
+
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    is_english, translated_content = translator.translate("Hola amigo")
+
+    assert is_english is False
+    assert translated_content == "Hello there"
+
+
+def test_empty_response_fallback(monkeypatch):
+    mock_response = {
+        "message": {
+            "content": ""
+        }
+    }
+
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    original_content = "Test message"
+    is_english, translated_content = translator.translate(original_content)
+
+    assert is_english is True
+    assert translated_content == original_content
+
+
+def test_raw_yes_no_format(monkeypatch):
+    mock_response = {
+        "message": {
+            "content": "No\nThis is the translation"
+        }
+    }
+
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    is_english, translated_content = translator.translate("Hola mundo")
+
+    assert is_english is False
+    assert translated_content == "This is the translation"
+
+def test_llm_english_returns_original_text(monkeypatch):
+    mock_response = {"message": {"content": "ENGLISH: Yes\nTEXT: This is an English message"}}
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    original_content = "This is an English message"
+    is_english, translated_content = translator.translate(original_content)
+    assert is_english is True
+    assert translated_content == original_content
+
+
+def test_llm_whitespace_text_returns_original_text(monkeypatch):
+    mock_response = {"message": {"content": "ENGLISH: Yes\nTEXT:   "}}
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    original_content = "This is a non-English message"
+    is_english, translated_content = translator.translate(original_content)
+    assert is_english is True
+    assert translated_content == original_content
+
+
+#given that the parsing logic splits on colons, we need to test that the text line preserves colons
+def test_text_line_preserves_colons(monkeypatch):
+    mock_response = {"message": {"content": "ENGLISH: Yes\nTEXT: This is a: random colon message"}}
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    original_content = "This is a: random colon message"
+    is_english, translated_content = translator.translate(original_content)
+    assert is_english is True
+    assert translated_content == original_content
+
+
+def test_multiple_input_lines_takes_last(monkeypatch):
+    mock_response = {"message": {"content": "ENGLISH: No\nTEXT: This is a non-English message\nENGLISH: Yes\nTEXT: This is a random message"}}
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    original_content = "This is a non-English message\nThis is a random message"
+    is_english, translated_content = translator.translate(original_content)
+    assert is_english is False
+    assert translated_content == "This is a random message"
+
+
+def test_llm_japanese_to_english_translation(monkeypatch):
+    mock_response = {"message": {"content": "ENGLISH: No\nTEXT: Hello, this is a complex sentences with a lot of terms to test accuracy of translation"}}
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    original_content = "こんにちは, これは複雑な文です。多くの用語をテストするために、翻訳の正確性をテストします。"
+    is_english, translated_content = translator.translate(original_content)
+    assert is_english is False
+    assert translated_content == "Hello, this is a complex sentences with a lot of terms to test accuracy of translation"
+
+def test_llm_thai_to_english_translation(monkeypatch):
+    mock_response = {"message": {"content": "ENGLISH: No\nTEXT: Hello, this is a complex sentences with a lot of terms to test accuracy of translation"}}
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    original_content = "สวัสดี, นี่คือประโยคที่ซับซ้อนมากที่สุดที่สามารถทดสอบความแม่นยำของการแปล"
+    is_english, translated_content = translator.translate(original_content)
+    assert is_english is False
+    assert translated_content == "Hello, this is a complex sentences with a lot of terms to test accuracy of translation"
+
+def test_llm_vietnamese_to_english_translation(monkeypatch):
+    mock_response = {"message": {"content": "ENGLISH: No\nTEXT: Hello, this is a complex sentences with a lot of terms to test accuracy of translation"}}
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    original_content = "Xin chào, đây là một câu phức tạp với nhiều thuật ngữ để kiểm tra độ chính xác của bản dịch"
+    is_english, translated_content = translator.translate(original_content)
+    assert is_english is False
+    assert translated_content == "Hello, this is a complex sentences with a lot of terms to test accuracy of translation"
+
+def test_llm_korean_to_english_translation(monkeypatch):
+    mock_response = {"message": {"content": "ENGLISH: No\nTEXT: Hello, this is a complex sentences with a lot of terms to test accuracy of translation"}}
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    original_content = "안녕하세요, 이것은 복잡한 문장입니다. 많은 용어를 테스트하기 위해 번역 정확도를 테스트합니다."
+    is_english, translated_content = translator.translate(original_content)
+    assert is_english is False
+    assert translated_content == "Hello, this is a complex sentences with a lot of terms to test accuracy of translation"
+
+#if there is no extractable content, None is inputted into the LLM and the original text is returned, ensuring NodeBB doesn't crash
+def test_no_response_fallback(monkeypatch):
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: None)
+    original_content = "Bonjour"
+    is_english, translated_content = translator.translate(original_content)
+    assert is_english is True
+    assert translated_content == original_content
+
+def test_non_string_response_fallback(monkeypatch):
+    mock_response = {"message": {"content": None}}
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    original_content = "Hello"
+    is_english, translated_content = translator.translate(original_content)
+    assert is_english is True
+    assert translated_content == original_content
+
+#mocking raising an error, and ensuring original text is returned, NodeBB doesn't crash
+def test_chat_raises_returns_original(monkeypatch):
+    def boom(**kwargs):
+        raise RuntimeError("ollama down")
+    monkeypatch.setattr(translator.client, "chat", boom)
+    original_content = "Bonjour"
+    is_english, translated_content = translator.translate(original_content)
+    assert is_english is True
+    assert translated_content == original_content
+
+def test_llm_conversational_filler(monkeypatch):
+    # The LLM adds chatty text before the actual formatted keys
+    mock_response = {
+        "message": {
+            "content": "I can help with that!\nENGLISH: No\nTEXT: I love coding"
+        }
+    }
+
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    is_english, translated_content = translator.translate("Me encanta programar")
+
+    assert is_english is False
+    assert translated_content == "I love coding"
+
+
+def test_llm_preserves_emojis(monkeypatch):
+    # Emojis and special characters must not be lost in translation
+    mock_response = {
+        "message": {
+            "content": "ENGLISH: No\nTEXT: Hello world! 🌍✨"
+        }
+    }
+
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    original_content = "¡Hola mundo! 🌍✨"
+    is_english, translated_content = translator.translate(original_content)
+
+    assert is_english is False
+    assert translated_content == "Hello world! 🌍✨"
+
+
+def test_llm_extra_spaces_in_response(monkeypatch):
+    # The LLM sometimes adds weird spacing around the text
+    mock_response = {
+        "message": {
+            "content": "ENGLISH: No\nTEXT:    This has extra spaces   "
+        }
+    }
+
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    is_english, translated_content = translator.translate("Esto tiene espacios extra")
+
+    assert is_english is False
+    assert translated_content.strip() == "This has extra spaces"
+
+# Reordered Keys: LLMs sometimes print the requested fields in the wrong order
+def test_llm_reordered_keys(monkeypatch):
+    mock_response = {
+        "message": {
+            "content": "TEXT: This is a translated message\nENGLISH: No"
+        }
+    }
+
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    is_english, translated_content = translator.translate("Este es un mensaje traducido")
+
+    assert is_english is False
+    assert translated_content == "This is a translated message"
+
+
+# Invalid Boolean Text: The LLM outputs something other than Yes/No (e.g., "Maybe" or "False")
+def test_llm_invalid_english_value_fallback(monkeypatch):
+    mock_response = {
+        "message": {
+            "content": "ENGLISH: Not Sure\nTEXT: Hello"
+        }
+    }
+
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    original_content = "Bonjour"
+    is_english, translated_content = translator.translate(original_content)
+
+    # If the parser defaults to treating unknown values as English (True) to be safe:
+    assert is_english is True
+    assert translated_content == original_content
+
+
+# HTML/Forum Tags: Since this is for NodeBB, we need to ensure HTML/Markdown isn't stripped
+def test_llm_preserves_html_and_markdown_tags(monkeypatch):
+    mock_response = {
+        "message": {
+            "content": "ENGLISH: No\nTEXT: This is **bold** and <i>italic</i>"
+        }
+    }
+
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    is_english, translated_content = translator.translate("Esto es **audaz** y <i>cursiva</i>")
+
+    assert is_english is False
+    assert translated_content == "This is **bold** and <i>italic</i>"
+
+
+# API Structural Failure: Ollama returns an error dictionary instead of a "message" dictionary
+def test_api_structural_failure_fallback(monkeypatch):
+    # Missing the "message" key completely, which would normally cause a KeyError
+    mock_response = {
+        "error": "model qwen3:0.6b not found, try pulling it first"
+    }
+
+    monkeypatch.setattr(translator.client, "chat", lambda **kwargs: mock_response)
+    original_content = "Test message"
+    is_english, translated_content = translator.translate(original_content)
+
+    # The try/except block should catch the KeyError and return the fallback
     assert is_english is True
     assert translated_content == original_content