fix: probably the laziest fix to the search bug you've ever seen#34
Closed
cirex-web wants to merge 2 commits into
Closed
fix: probably the laziest fix to the search bug you've ever seen#34cirex-web wants to merge 2 commits into
cirex-web wants to merge 2 commits into
Conversation
railway-app
Bot
temporarily deployed
to
Clean Code Team (nodebb) / nodebb-spring-26-clean-cod-pr-34
|
🚅 Deployed to the nodebb-spring-26-clean-cod-pr-34 environment in Clean Code Team (nodebb)
|
railway-app
Bot
temporarily deployed
to
Clean Code Team (nodebb) / nodebb-spring-26-clean-cod-pr-34
|
It works but fails the linter. |
|
Closing this line. Test fails due to undesired behavior: assuming that low level search cares about categories (it is possible it doesn't, as in the case of the failing testcase). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@yuriiShmal try to break this :P