Add missing url to vendored nodebb-theme-harmony metadata#31
Merged
Conversation
marcothephoenix65
changed the title
marcothephoenix65
changed the title
marcothephoenix65
changed the title
|
Code looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to the associated GitHub issues:
#15
Full path to the refactored files:
vendor/nodebb-theme-harmony-2.1.35/plugin.json
This change adds the url to the node bb harmony metadata to pass a check previously the solely failing one.
Without this change we would fail a CI test
To implement we added the nodebb harmony link to the metadata.
It was tested through the github CI check which all passed