Skip to content

Updating the ESS-DIVE submission #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Updating the ESS-DIVE submission #270

wants to merge 3 commits into from

Conversation

stephpenn1
Copy link
Member

I've begun to detail the steps post-pipeline (the follow up to making-a-new-release.md. Right now it's an outline, will become more detailed later. Any thoughts welcome!

@stephpenn1 stephpenn1 added the documentation Improvements or additions to documentation label Mar 6, 2025
@stephpenn1 stephpenn1 requested a review from bpbond March 6, 2025 17:18
@stephpenn1 stephpenn1 self-assigned this Mar 6, 2025
Copy link
Member

@bpbond bpbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great high-level outline! A few questions occurred to me while reading--see below.


0. Run processing pipeline to produce L1 data for synoptic and TEMPEST sites

1. Move L1 data to folders labeled `vX-X` \> `vX-X_SYN` and `vX-X` \> `vX-X_TMP` . Each folder gets a copy of the `READMD.txt` and `README_vX-X.txt` files.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md ?


2. Prep package metadata files

- Produce flmd using `flmd-generator.R`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it obvious how to do this? Do you need to point the script to where the L1 data are?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, I think currently flmd-generator requires the files to be in the L1 folder (at least i havent tried otherwise) which would impact the steps here

- Produce flmd using `flmd-generator.R`
- Copy over `dd.csv` from previous version (this file does not change unless we change or add a new L1 column)
- Run `availability_graph.R` to produce availability graphs.
- Add saved graphs to quick start documents located in the FME Data Management folder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you create a new copy of the documents for each release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@bpbond
Copy link
Member

bpbond commented Mar 6, 2025

This PR is related to #262

@bpbond
Copy link
Member

bpbond commented Mar 6, 2025

Test failing:

! 'expand_df' is not an exported object from 'namespace:compasstools'

Ah, sorry, this is my fault @stephpenn1 -- I moved this function from compasstools to here as part of #267 but that's on the v2-dev branch.

Two options; let me know which you prefer:

  1. I can put it back into compasstools for now
  2. You can re-target this PR to v2-dev

@bpbond
Copy link
Member

bpbond commented Mar 6, 2025

Ugh, realizing that I've broken every future PR to main. Creating a tag for v1.x PRs to use.

@bpbond
Copy link
Member

bpbond commented Mar 6, 2025

Creating a tag for v1.x PRs to use.

If not obvious what's happening here, lmk, happy to explain in more detail. -B

@stephpenn1
Copy link
Member Author

Creating a tag for v1.x PRs to use.

If not obvious what's happening here, lmk, happy to explain in more detail. -B

It's not :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants