-
Notifications
You must be signed in to change notification settings - Fork 0
Updating the ESS-DIVE submission #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great high-level outline! A few questions occurred to me while reading--see below.
|
||
0. Run processing pipeline to produce L1 data for synoptic and TEMPEST sites | ||
|
||
1. Move L1 data to folders labeled `vX-X` \> `vX-X_SYN` and `vX-X` \> `vX-X_TMP` . Each folder gets a copy of the `READMD.txt` and `README_vX-X.txt` files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README.md
?
|
||
2. Prep package metadata files | ||
|
||
- Produce flmd using `flmd-generator.R` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it obvious how to do this? Do you need to point the script to where the L1 data are?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, I think currently flmd-generator requires the files to be in the L1 folder (at least i havent tried otherwise) which would impact the steps here
- Produce flmd using `flmd-generator.R` | ||
- Copy over `dd.csv` from previous version (this file does not change unless we change or add a new L1 column) | ||
- Run `availability_graph.R` to produce availability graphs. | ||
- Add saved graphs to quick start documents located in the FME Data Management folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you create a new copy of the documents for each release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
This PR is related to #262 |
Test failing:
Ah, sorry, this is my fault @stephpenn1 -- I moved this function from Two options; let me know which you prefer:
|
Ugh, realizing that I've broken every future PR to |
If not obvious what's happening here, lmk, happy to explain in more detail. -B |
It's not :) |
I've begun to detail the steps post-pipeline (the follow up to
making-a-new-release.md
. Right now it's an outline, will become more detailed later. Any thoughts welcome!