[DDING-000] 동아리 지원하기 - File Type 답변 로직 추가 #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5uhwann
requested review from
wonjunYou,
KoSeonJe and
Seooooo24
as code owners
|
Caution Review failedThe pull request is closed. Walkthrough이번 변경 사항은 Changes
Sequence Diagram(s)sequenceDiagram
participant Service as FacadeUserFormApplicationServiceImpl
participant Metadata as FileMetaDataService
participant Answer as FormAnswer
participant Form as Form
Service->>Answer: 폼 답안 처리
alt FieldType이 FILE인 경우
Service->>Metadata: updateStatusToCoupled(answerValue, FORM_FILE, formId)
end
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (3)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/java/ddingdong/ddingdongBE/domain/formapplication/service/FacadeUserFormApplicationServiceImpl.java (1)
47-58: 파일 상태 업데이트 시 예외 처리 로직 추가를 고려해보세요.파일 메타데이터 상태 업데이트 시 발생할 수 있는 예외 상황(예: 파일이 존재하지 않는 경우)에 대한 처리가 필요해 보입니다.
다음과 같은 예외 처리 로직 추가를 제안드립니다:
if (formAnswer.getFormField().getFieldType() == FieldType.FILE) { + try { fileMetaDataService.updateStatusToCoupled( formAnswer.getValue(), FORM_ANSWER_FILE, formAnswer.getId() ); + } catch (FileNotFoundException e) { + throw new BusinessException(ErrorCode.FILE_NOT_FOUND); + } catch (Exception e) { + throw new BusinessException(ErrorCode.FILE_PROCESSING_ERROR); + } }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/main/java/ddingdong/ddingdongBE/domain/filemetadata/entity/DomainType.java(1 hunks)src/main/java/ddingdong/ddingdongBE/domain/formapplication/service/FacadeUserFormApplicationServiceImpl.java(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build and analyze
🔇 Additional comments (2)
src/main/java/ddingdong/ddingdongBE/domain/filemetadata/entity/DomainType.java (1)
19-20: 구현이 적절해 보입니다!
FORM_ANSWER_FILE상수가 기존 도메인 타입들과 일관된 네이밍 패턴을 따르고 있으며, 열거형 상수 목록의 마지막에 적절하게 배치되었습니다.src/main/java/ddingdong/ddingdongBE/domain/formapplication/service/FacadeUserFormApplicationServiceImpl.java (1)
3-28: 의존성 주입이 깔끔하게 구현되었습니다!
FileMetaDataService와FORM_ANSWER_FILE상수의 import가 명확하게 되어있고, 의존성 주입이@RequiredArgsConstructor를 통해 적절하게 처리되었습니다.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 작업 내용
🤔 고민했던 내용
💬 리뷰 중점사항
Summary by CodeRabbit