Skip to content

Conversation

@elsa-bismuth
Copy link
Contributor

Update Activity Features and Testing

♻️ Current situation & Problem

This PR addresses improvements and additions related to the activity management system. It includes updating the onboarding experience, refining the activity suggestion flow, and ensuring adequate test coverage.

⚙️ Release Notes

  • Added video link for activity suggestions to enhance user engagement.
  • Added tests for the activity manager to improve reliability and ensure correctness.
  • Updated icon onboarding for a better first-time user experience.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Turquoise-T Turquoise-T self-requested a review March 12, 2025 07:40
Copy link
Contributor

@Turquoise-T Turquoise-T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make the code works locally first

@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 0.45662% with 218 lines in your changes missing coverage. Please review.

Project coverage is 13.97%. Comparing base (11c5065) to head (9c031ae).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...anford360/Activity/View/ActivityControlPanel.swift 0.00% 139 Missing ⚠️
Stanford360/Activity/View/ActivityButtonView.swift 0.00% 29 Missing ⚠️
...anford360/Activity/View/AddActivitySheetView.swift 0.00% 22 Missing ⚠️
...anford360/Activity/View/ActivityDiscoverView.swift 0.00% 21 Missing ⚠️
Stanford360/Activity/View/ActivityTabView.swift 0.00% 4 Missing ⚠️
Stanford360/Dashboard/Models/PatientManager.swift 0.00% 2 Missing ⚠️
Stanford360/Activity/Model/HealthKitManager.swift 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   13.24%   13.97%   +0.73%     
==========================================
  Files          95       97       +2     
  Lines        4269     4447     +178     
==========================================
+ Hits          565      621      +56     
- Misses       3704     3826     +122     
Files with missing lines Coverage Δ
Stanford360/Activity/Model/ActivityManager.swift 100.00% <ø> (+92.54%) ⬆️
Stanford360/Onboarding/KidsOnboarding.swift 94.60% <100.00%> (ø)
Stanford360/Activity/Model/HealthKitManager.swift 20.41% <0.00%> (ø)
Stanford360/Dashboard/Models/PatientManager.swift 42.19% <0.00%> (+0.65%) ⬆️
Stanford360/Activity/View/ActivityTabView.swift 0.00% <0.00%> (ø)
...anford360/Activity/View/ActivityDiscoverView.swift 0.00% <0.00%> (ø)
...anford360/Activity/View/AddActivitySheetView.swift 0.00% <0.00%> (ø)
Stanford360/Activity/View/ActivityButtonView.swift 0.00% <0.00%> (ø)
...anford360/Activity/View/ActivityControlPanel.swift 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11c5065...9c031ae. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elsa-bismuth
Copy link
Contributor Author

I couldn't fully test it, but I think that it works locally

@elsa-bismuth elsa-bismuth reopened this Mar 12, 2025
@kkellybonilla
Copy link
Contributor

@elsa-bismuth it's failing swiftlint, periphery, & the build test ci check itself, so you'll have to fix this before merging

@elsa-bismuth elsa-bismuth force-pushed the elsa-bismuth/testing branch from fd8d7a2 to 5b9e2c1 Compare March 12, 2025 18:48
@elsa-bismuth elsa-bismuth marked this pull request as draft March 12, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants