Sidebar: Show a hidden label for an empty value; attribute-specific empty value #13
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/scripts/components/sidebar.js: - Support attribute property "emptyValue" to specify an attribute-specific value to be represented as "[empty]".
app/scripts/components/sidebar.js: - Show the attribute label for an empty value even if it is otherwise hidden with property sidebarHideLabel, so that the user can see what is empty.
|
@Traubert, the forthcoming Achemenet and BALT corpora use a feature added in this pull request, so I’d be grateful if you could review (and merge) this relatively soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make two minor enhancements to displaying empty values in the sidebar:
emptyValuein attribute configurations to specify a value which is shown as “[empty]“, in addition to a completely empty value. This can be used if e.g. the underscore is used to denote an empty value.The first feature is in use in the Korp test instance for Achemenet and BALT, but the second one is not currently used.