Nuget bumps #4050
Merged
Nuget bumps #4050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- RestSharp and RestSharp.Serializers.NewtonsoftJson to 113.0.0 - System.IdentityModel.Tokens.Jwt to 8.15.0 - System.Text.Encodings.Web to 10.0.1 - PuppeteerSharp to 20.2.5 - Swashbuckle.AspNetCore to 10.0.1 - Microsoft.IdentityModel.Tokens to 8.15.0 Also updated a using directive in Program.cs to reflect changes in the OpenAPI package structure. No functional code changes were made.
Upgraded bunit to 2.2.2 and Microsoft.NET.Test.Sdk to 18.0.1 in the test project. Refactored UiRsbLinkTest.cs to use new bunit APIs, including BunitContext, BunitNavigationManage.
Upgraded the NUnit3TestAdapter NuGet package in FWO.Test.csproj
SolidProgramming
added
the
dependencies
There was a problem hiding this comment.
Pull request overview
This PR updates multiple NuGet packages across the codebase to their latest versions, addressing several open issues. The update includes both minor version bumps (PuppeteerSharp, RestSharp, JWT tokens) and major version updates (bunit 1.x → 2.x, Swashbuckle 8.x → 10.x, Microsoft.NET.Test.Sdk 17.x → 18.x).
Key changes:
- Major framework updates: bunit upgraded to 2.2.2 with corresponding API migration in test code
- Security updates: System.IdentityModel.Tokens.Jwt and Microsoft.IdentityModel.Tokens updated to 8.15.0
- Breaking changes: Swashbuckle.AspNetCore updated to 10.0.1 with incomplete namespace migration
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| FWO.UI/FWO.Ui.csproj | Updates PuppeteerSharp to 20.2.5 |
| UiRsbLinkTest.cs | Migrates test code to bunit 2.x API (TestContext → BunitContext, RenderComponent → Render, FakeNavigationManager → BunitNavigationManager); removes unused imports; adds explicit typing |
| FWO.Test/FWO.Test.csproj | Updates bunit to 2.2.2, PuppeteerSharp to 20.2.5, NUnit3TestAdapter to 5.2.0, Microsoft.NET.Test.Sdk to 18.0.1, Microsoft.IdentityModel.Tokens to 8.15.0 |
| FWO.Middleware.Server/Program.cs | Changes using statement from Microsoft.OpenApi.Models to Microsoft.OpenApi (incomplete - causes compilation error) |
| FWO.Middleware.Server.csproj | Updates PuppeteerSharp to 20.2.5 and Swashbuckle.AspNetCore to 10.0.1 |
| FWO.Report/FWO.Report.csproj | Updates PuppeteerSharp to 20.2.5 |
| FWO.Mail/FWO.Mail.csproj | Updates System.Text.Encodings.Web to 10.0.1 (version likely doesn't exist) |
| FWO.Config.File.csproj | Updates System.IdentityModel.Tokens.Jwt to 8.15.0 |
| FWO.Api.Client.csproj | Updates RestSharp and RestSharp.Serializers.NewtonsoftJson to 113.0.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
roles/middleware/files/FWO.Middleware.Server/FWO.Middleware.Server.csproj
Show resolved
Hide resolved
Contributor
Author
|
@tpurschke Please make sure it installs/upgrades for you. I did an upgrade and the dotnet tests. The install test also works. Don't know why copilot thinks it's not compiling. |
|
tpurschke
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
For NUnit3TestAdapter is 6.0.0 available but that completly breaks all of our tests. I investigated a bit and everytime we read the config from testhost it crashes. It may be because if the "criticalconfigvaluesloaded" function can't find a value it throws an error(in debug) and in release in does environment.exit(). Also i read that they fixed "Attempting to execute a native assembly crashes the runner.", maybe they haven't because i found that the ConfigFile test execute a function via reflection.