-
Notifications
You must be signed in to change notification settings - Fork 321
Support for materials #1815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Support for materials #1815
Conversation
This looks great, I wonder if there is ever a use case for a material to be a string in as an option in addition to these nice material classes you have here. I was wondering if something like this would be possible / useful
|
@shimwell it would certainly be nice to have some predefined materials, and maybe allow to use the material name for other things too. But let's start with making CI green. |
b5d0434
to
0ea2c5e
Compare
0ea2c5e
to
0dbe26c
Compare
38218df
to
36308a6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1815 +/- ##
==========================================
+ Coverage 95.54% 95.67% +0.12%
==========================================
Files 28 29 +1
Lines 7319 7485 +166
Branches 1102 1125 +23
==========================================
+ Hits 6993 7161 +168
+ Misses 195 194 -1
+ Partials 131 130 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Material support in step exporting will get better in OCCT: |
Would probably nice to have a set of materials to get started, but I think, any real-world application will require custom material sets. (edit: for example https://physicallybased.info) |
VRML export runs, but is not correct yet. |
Implemented material support.
In this approach, materials are stored in python dataclasses, the OpenCascade objects are only created when building the assembly.
Tests/docs are missing at the moment.