add caching to GlStateManager#glViewport#3309
Open
crosby-moe wants to merge 1 commit intoCaffeineMC:devfrom
Open
add caching to GlStateManager#glViewport#3309crosby-moe wants to merge 1 commit intoCaffeineMC:devfrom
GlStateManager#glViewport#3309crosby-moe wants to merge 1 commit intoCaffeineMC:devfrom
Conversation
douira
requested changes
Feb 2, 2026
Contributor
douira
left a comment
douira
left a comment
There was a problem hiding this comment.
PR seems ok to me in general, though I don't know anything about the code we're mixing into here. I've just requested two small syntactic changes.
Comment on lines
+11
to
+14
| @Unique private static int viewportX; | ||
| @Unique private static int viewportY; | ||
| @Unique private static int viewportWidth; | ||
| @Unique private static int viewportHeight; |
Contributor
There was a problem hiding this comment.
our code style is to put the annotation on its own line.
| "features.render.model.ItemBlockRenderTypesMixin", | ||
| "features.render.model.item.ItemRendererMixin", | ||
| "features.render.particle.SingleQuadParticleMixin", | ||
| "features.render.viewport.GlStateManagerMixin", |
Contributor
There was a problem hiding this comment.
this will need conflict resolution since it seems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
RenderPassobject created caused a non-memoized call toGL11#glViewport, usually with the same argumentsSumming up all instances of
GlStateManager#glViewportin a spark profile from a simple world with an uncapped framerate:Before: 214.6ms in 60s, or .35% of render thread [spark profile]
After: 3.2ms in 60s [spark profile]