Round capacity estimates to multiples of 4 to make sure allocations are always aligned#3522
Open
xirreal wants to merge 1 commit intoCaffeineMC:devfrom
Open
Round capacity estimates to multiples of 4 to make sure allocations are always aligned#3522xirreal wants to merge 1 commit intoCaffeineMC:devfrom
xirreal wants to merge 1 commit intoCaffeineMC:devfrom
Conversation
…re always aligned
douira
requested changes
Feb 24, 2026
| newCapacity = (long) (requiredTotalSize * FEW_SEGMENTS_GROWTH_FACTOR); | ||
| } | ||
| return newCapacity; | ||
| return (newCapacity + 3) & ~3; |
Contributor
There was a problem hiding this comment.
Please add the elaboration you gave on discord and the fact that due to
, an unaligned capacity causes an unaligned tail and that causes an unaligned segment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3509