use ipython display formatter directly for missing _repr_mimebundle #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix #232, #284
I am not sure this will be fully backwards compatible, IPython code mentions that
_repr_mimebundle_is there since 6.x and theDisplayFormattershould take care of rendering all registered mimetypes, but still.My problem was that graphviz
Sourceobjects expose only_repr_mimebundlewhich is not used by the metakernel so I had to wrap that, but this looks like a simple enough fix that worked for me.DisplayFormattercan be configured, perhaps the kernel kwargs should be passed to it, not sure.