Skip to content

Don't include descendant terms in the sidebar search - #248

Draft
OrdiNeu wants to merge 2 commits into
develop-v3from
bugfix/dont-include-descendants
Draft

Don't include descendant terms in the sidebar search#248
OrdiNeu wants to merge 2 commits into
develop-v3from
bugfix/dont-include-descendants

Conversation

@OrdiNeu

@OrdiNeu OrdiNeu commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

Description

  • This turns off descendant search in Beacon search, which is on by default, but in our (OMOP) use-case it ends up bloating the size of the request in SQL by a lot.

As an example, this is what the query looks like when you search on "biopsy":
image

Expected Behaviour

  • This turns off descendant search

Screenshots (if appropriate)

Before PR

image

Types of Change(s)

  • 🪲 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

Has it been tested for:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • Prettier linter doesn't return errors
  • Production branch PR browser testing: Chrome, Firefox, Edge, etc.
  • Locally tested
  • Dev server tested
  • Production tested when merging into stable/production branch
  • Runbook tasks pass locally/on UHN-Dev
  • If visuals have changed, Runbook has been updated with new screenshots

@OrdiNeu
OrdiNeu requested a review from mshadbolt February 20, 2026 21:18
@OrdiNeu OrdiNeu changed the title Bugfix/dont include descendants Don't include descendant terms in the sidebar search Feb 20, 2026
@mshadbolt

Copy link
Copy Markdown
Contributor

Do we still want to do this or does CanDIG/candig-api#48 fix the issue?

@mshadbolt

Copy link
Copy Markdown
Contributor

we will wait on merging this until we test out the PR mentioned above

@OrdiNeu
OrdiNeu marked this pull request as draft February 24, 2026 20:12
@mshadbolt
mshadbolt removed their request for review February 26, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants