Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphabetically sort MTGO Cubes so they are easier to find #6201

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

myyk
Copy link

@myyk myyk commented Sep 26, 2024

Implements #6200.

I have one commit as moves and one commit as edits for easier reviewing. It's too bad that it didn't show them as moves for all the .draft files in github, but that's out of my control.

@tool4ever tool4ever linked an issue Sep 28, 2024 that may be closed by this pull request
@tehdiplomat
Copy link
Contributor

Is this going to cause issues for people who are in between gauntlets, or have their preferences pointed to the old names?

@myyk
Copy link
Author

myyk commented Oct 23, 2024

@tehdiplomat, I'm unfamiliar with Gauntlet, but as far as I can tell from playing with the UI it doesn't seem related to draft or cube so I think those are totally separate and safe if in progress.

As far as drafted decks from a cube go, the decks seem unrelated to the cube they were drafted from. And there's no in progress saving of a draft, so nothing to worry about from that front.

tehdiplomat
tehdiplomat previously approved these changes Oct 25, 2024
@myyk
Copy link
Author

myyk commented Oct 25, 2024

@tehdiplomat I triple checked all changes after fixing the 1 typo I found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alphabetically sort MTGO Cubes so they are easier to find
2 participants