Verify token kind uniqueness #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use token kind to identify tokens in the price feed. This makes sure there aren't any duplicates without going too deep into refactoring that.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements validation to ensure token kind uniqueness in the token configuration to prevent duplicates that could cause issues in the price feed identification system.
- Modifies config resolution functions to return
Result<ServerConfig>instead ofServerConfigto handle validation errors - Adds a new validation function
check_token_configthat verifies no duplicate token kinds exist - Updates main function and test to handle the new error-returning configuration resolution
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/shielder-relayer/src/main.rs | Updates main function to handle error from config resolution |
| crates/shielder-relayer/src/config/tests.rs | Modifies test to handle and return Result from config resolution |
| crates/shielder-relayer/src/config/mod.rs | Adds token kind uniqueness validation and updates config functions to return Results |
| README.md | Formats license list items using markdown bullet points |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Marcin-Radecki
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use token kind to identify tokens in the price feed. This makes sure there aren't any duplicates without going too deep into refactoring that.